Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 302083006: Fixed layout test fast/canvas/canvas-bg.html to work with accelerated canvas (Closed)

Created:
6 years, 6 months ago by Justin Novosad
Modified:
6 years, 6 months ago
Reviewers:
Stephen White
CC:
blink-reviews
Visibility:
Public.

Description

Fixed layout test fast/canvas/canvas-bg.html to work with accelerated canvas This patch removes the semi-transparent color used int the test, which was irrelevant to the feature being testes and was causing the test to fail due to rounding errors in compositing. BUG=368008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-bg.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-bg-expected.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Justin Novosad
PTAL
6 years, 6 months ago (2014-05-30 17:49:39 UTC) #1
Stephen White
LGTM
6 years, 6 months ago (2014-05-30 18:33:20 UTC) #2
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 6 months ago (2014-05-30 18:46:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/302083006/1
6 years, 6 months ago (2014-05-30 18:46:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-30 19:23:19 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:52:19 UTC) #6
Message was sent while issue was closed.
Change committed as 175164

Powered by Google App Engine
This is Rietveld 408576698