LayoutTests/fast/css-grid-layout/stale-grid-layout.html - Issue 302083005: Don't leave stale pointers into m_grid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/stale-grid-layout.html

Issue 302083005: Don't leave stale pointers into m_grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <keygen>

	3 <div style="display: grid;">The test checks that we don't add non-children of th e grid into the grid representation<br>This test has passed if it didn't crash u nder ASAN
	Julien - ping for review 2014/06/10 00:18:32 Nit: Missing final dot. Nit: Missing final dot.
	4 <embed type=something-not-js>

	5 </div>

	6 <style>

	7 embed { position: absolute; }

	8 .foo ~ .c1 { animation-delay: 45762s; }
	Julien - ping for review 2014/06/10 00:18:32 45762s is a lot of seconds but also not something 45762s is a lot of seconds but also not something that is going to be run. Also there is no .foo or .c1.
	9 </style>

	10 <script>

	11 if (window.testRunner)

	12 testRunner.dumpAsText();

	13

	14 function crash() {

	15 var highlight = document.createElementNS("http://www.w3.org/1999/xhtml", "hi ghlight");

	16 highlight.setAttribute("class", "c1");

	17 document.body.appendChild(highlight);

	18

	19 for (i=0; i != 8; i++)

	20 eventSender.keyDown("\t");

	21 eventSender.keyDown("X");

	22 }

	23

	24 if (!window.eventSender)

	25 alert("This test needs to be run under DumpRenderTree.");

	26 else

	27 document.addEventListener("DOMContentLoaded", crash, false);

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/stale-grid-layout-2.html » ('j') | no next file with comments »