Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: Source/core/rendering/RenderEmbeddedObject.cpp

Issue 302083002: Always give RenderParts a RenderLayer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderIFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderEmbeddedObject.cpp
diff --git a/Source/core/rendering/RenderEmbeddedObject.cpp b/Source/core/rendering/RenderEmbeddedObject.cpp
index a4aa641643af09ebcd0395a9f07376d804dda4fd..08e3276a8af9aabac22e0d447196ca1ed4f211ea 100644
--- a/Source/core/rendering/RenderEmbeddedObject.cpp
+++ b/Source/core/rendering/RenderEmbeddedObject.cpp
@@ -66,11 +66,12 @@ RenderEmbeddedObject::~RenderEmbeddedObject()
LayerType RenderEmbeddedObject::layerTypeRequired() const
{
- LayerType type = RenderPart::layerTypeRequired();
- if (type != NoLayer)
- return type;
-
- return requiresAcceleratedCompositing() ? NormalLayer : NoLayer;
+ // This just use RenderPart::layerTypeRequired, because RenderLayerCompositor
esprehn 2014/06/03 03:49:17 typo, -> uses
esprehn 2014/06/03 03:49:17 typo, -> uses
+ // doesn't loop through RenderEmbeddedObjects the way it does frames in order
+ // to update the self painting bit on their RenderLayer.
+ if (requiresAcceleratedCompositing())
+ return NormalLayer;
+ return RenderPart::layerTypeRequired();
}
static String unavailablePluginReplacementText(Node* node, RenderEmbeddedObject::PluginUnavailabilityReason pluginUnavailabilityReason)
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderIFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698