Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 302063005: Fix crash when calling getMsg with no options. (Closed)

Created:
6 years, 6 months ago by dmazzoni
Modified:
6 years, 6 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix crash when calling getMsg with no options. (This is cherry-picking a single bug fix from ChromeVox upstream.) The repro is this html: <div tabIndex=0 role="slider" aria-valuenow="20"></div> The bug happens when cvox.BrailleUtil.getState calls cvox.ChromeVox.msgs.getMsg to see if the "_brl" translation exists, and passes it 'aria_value_now_brl' in this particular case, whose value is just "$1". If you don't pass it an argument, you get '' back, and that throws an error because a message should never return the empty string. BUG=379296 R=plundblad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/braille_util.js View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/third_party/chromevox/chromeVoxChromePageScript.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
dmazzoni
6 years, 6 months ago (2014-05-30 21:44:36 UTC) #1
chromium-reviews
LGTM FWIW, I think this should affect the background page as well, but presumably not ...
6 years, 6 months ago (2014-05-30 23:25:44 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 6 months ago (2014-06-02 19:26:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/302063005/1
6 years, 6 months ago (2014-06-02 19:28:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 19:28:42 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-02 19:28:42 UTC) #6
Peter Lundblad
lgtm
6 years, 6 months ago (2014-06-02 19:33:34 UTC) #7
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 6 months ago (2014-06-02 19:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/302063005/1
6 years, 6 months ago (2014-06-02 19:36:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 20:20:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 20:24:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71128)
6 years, 6 months ago (2014-06-02 20:24:07 UTC) #12
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 6 months ago (2014-06-04 01:13:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/302063005/1
6 years, 6 months ago (2014-06-04 01:14:45 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 01:19:17 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 01:22:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71461)
6 years, 6 months ago (2014-06-04 01:22:53 UTC) #17
dmazzoni
6 years, 6 months ago (2014-06-04 14:08:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 manually as r274815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698