Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302043005: Change SavePackage to use GetVisibleEntry instead of GetActiveEntry. (Closed)

Created:
6 years, 6 months ago by nasko
Modified:
6 years, 6 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Change SavePackage to use GetVisibleEntry instead of GetActiveEntry. BUG=273710 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274370

Patch Set 1 #

Patch Set 2 : Change from LastCommitted to Visible. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/download/save_package.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nasko
rdsmith@, can you review this CL for OWNERS please? Thanks in advance!
6 years, 6 months ago (2014-05-30 20:19:50 UTC) #1
Randy Smith (Not in Mondays)
lgtm
6 years, 6 months ago (2014-05-31 18:28:54 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 6 months ago (2014-05-31 23:20:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/302043005/1
6 years, 6 months ago (2014-05-31 23:20:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-01 01:06:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 02:03:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/37086)
6 years, 6 months ago (2014-06-01 02:03:43 UTC) #7
nasko
Randy, Can you take another look? After discussion, it looks like the more appropriate behavior ...
6 years, 6 months ago (2014-06-02 18:50:41 UTC) #8
Randy Smith (Not in Mondays)
Still lgtm.
6 years, 6 months ago (2014-06-02 19:26:35 UTC) #9
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 6 months ago (2014-06-02 20:24:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/302043005/20001
6 years, 6 months ago (2014-06-02 20:24:33 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 23:42:50 UTC) #12
Message was sent while issue was closed. 
Change committed as 274370

Powered by Google App Engine
This is Rietveld 408576698