Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/gn/target_unittest.cc

Issue 302033004: GN: Don't link source sets into static libraries (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_unittest.cc
diff --git a/tools/gn/target_unittest.cc b/tools/gn/target_unittest.cc
index 6219374c947ad75c1dc2e39cab26b6a1dc3d673d..f9a1f972a43c36ed9af20a51159b8b39b7bb6f66 100644
--- a/tools/gn/target_unittest.cc
+++ b/tools/gn/target_unittest.cc
@@ -225,15 +225,14 @@ TEST_F(TargetTest, InheritLibs) {
EXPECT_EQ(1u, c_inherited.size());
EXPECT_TRUE(c_inherited.find(&d) != c_inherited.end());
- // B should have C in its inherited libs, but not D (the static library will
- // include the source sets's code).
+ // B should have C and D in its inherited libs.
const std::set<const Target*>& b_inherited = b.inherited_libraries();
- EXPECT_EQ(1u, b_inherited.size());
+ EXPECT_EQ(2u, b_inherited.size());
EXPECT_TRUE(b_inherited.find(&c) != b_inherited.end());
+ EXPECT_TRUE(b_inherited.find(&d) != b_inherited.end());
// A should have B in its inherited libs, but not any others (the shared
- // library will include the static library, which will include the source
- // set).
+ // library will include the static library and source set).
const std::set<const Target*>& a_inherited = a.inherited_libraries();
EXPECT_EQ(1u, a_inherited.size());
EXPECT_TRUE(a_inherited.find(&b) != a_inherited.end());
« no previous file with comments | « tools/gn/target.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698