Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 302033004: GN: Don't link source sets into static libraries (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

GN: Don't link source sets into static libraries Previously if a static library depended on a source set, we'd link it in. This can easily cause multiple inclusions of the source set's code if there are multiple shared libraries that depend on it. This patch forwards the source set up the dependency chain to the next linkable target (shared library or executable). This solves the multiple-definition problem. The downside is that if you make a static library that depends on a source set, it won't be "complete" in the sense that you can give it to somebody and it will have all of the files in it. If we need that capability, we'll add some kind of "complete" flag. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -20 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M tools/gn/target_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 6 months ago (2014-05-30 21:00:20 UTC) #1
scottmg
lgtm
6 years, 6 months ago (2014-05-31 02:55:08 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 6 months ago (2014-05-31 04:08:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/302033004/1
6 years, 6 months ago (2014-05-31 04:12:18 UTC) #4
brettw
The CQ bit was unchecked by brettw@chromium.org
6 years, 6 months ago (2014-05-31 04:41:54 UTC) #5
brettw
6 years, 6 months ago (2014-05-31 04:41:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r274024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698