Issue 302023003: Remove rounding in RenderGeometryMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302023003: Remove rounding in RenderGeometryMap. (Closed)

Created:
6 years, 6 months ago by dsinclair

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, eae

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove rounding in RenderGeometryMap. When working with FloatPoints in mapToContainer we currently round the accumulated offset before adding to the current point. This can lead to incorrect results when we add the two values together. This CL removes the rounding call on accumulatedOffset. BUG=371640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175105

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/rendering/RenderGeometryMap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/302023003/1

6 years, 6 months ago (2014-05-29 21:50:59 UTC) #3

Message was sent while issue was closed.

Change committed as 175105

Expand Messages | Collapse Messages