Chromium Code Reviews
Help | Chromium Project | Sign in
(49)

Issue 302004: Client certificates are looked up in ClientAuthHandler to get rid of manual C... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Jaime Soriano
Modified:
4 years, 2 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/329015 ] Client certificates are looked up in ClientAuthHandler to get rid of manual CA names list copy. R=wtc BUG=16830 TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in .pki/nssdb database.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -49 lines) Patch
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 5 chunks +38 lines, -48 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 3 (0 generated)
wtc
Jaime, I'm attending a conference on Monday - Wednesday. I won't be able to review ...
5 years, 9 months ago (2009-10-20 03:02:08 UTC) #1
Jaime Soriano
On 2009/10/20 03:02:08, wtc wrote: > Jaime, > > I'm attending a conference on Monday ...
5 years, 9 months ago (2009-10-20 07:56:46 UTC) #2
wtc
5 years, 9 months ago (2009-10-23 22:48:26 UTC) #3
Jamie, I will edit your CL and check it in in
http://codereview.chromium.org/329015
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f