Issue 302004: Client certificates are looked up in ClientAuthHandler to get rid of manual C...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302004: Client certificates are looked up in ClientAuthHandler to get rid of manual C... (Closed)

Created:
11 years, 2 months ago by Jaime Soriano

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

[Replaced by http://codereview.chromium.org/329015 ] Client certificates are looked up in ClientAuthHandler to get rid of manual CA names list copy. R=wtc BUG=16830 TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in .pki/nssdb database.

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -49 lines)			Patch
	M	net/socket/ssl_client_socket_nss.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/socket/ssl_client_socket_nss.cc	View		5 chunks	+38 lines, -48 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

Jaime, I'm attending a conference on Monday - Wednesday. I won't be able to review ...

11 years, 2 months ago (2009-10-20 03:02:08 UTC) #1

Jaime Soriano

On 2009/10/20 03:02:08, wtc wrote: > Jaime, > > I'm attending a conference on Monday ...

11 years, 2 months ago (2009-10-20 07:56:46 UTC) #2

wtc

11 years, 2 months ago (2009-10-23 22:48:26 UTC) #3

Jamie, I will edit your CL and check it in in
http://codereview.chromium.org/329015

Expand Messages | Collapse Messages