Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 302003015: Created a separate test page for gpu rasterization. (Closed)

Created:
6 years, 6 months ago by alokp
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Created a separate test page for gpu rasterization. The new test page uses the viewport tag which makes it easy to sample pixels from the screenshot. Adding the viewport tag to pixel_css3d page which is also used for pixel tests because it starts to fail due to unknown reasons on random bots. BUG=368495 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274469

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
A content/test/data/gpu/pixel_background.html View 1 chunk +53 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 4 chunks +9 lines, -11 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
alokp
6 years, 6 months ago (2014-06-02 23:11:09 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/302003015/diff/1/content/test/gpu/page_sets/gpu_rasterization_tests.py File content/test/gpu/page_sets/gpu_rasterization_tests.py (right): https://codereview.chromium.org/302003015/diff/1/content/test/gpu/page_sets/gpu_rasterization_tests.py#newcode14 content/test/gpu/page_sets/gpu_rasterization_tests.py:14: url='file://../../data/gpu/pixel_background.html', I'd suggest "pixel_blue_box.html" as a more descriptive ...
6 years, 6 months ago (2014-06-02 23:20:14 UTC) #2
alokp
https://codereview.chromium.org/302003015/diff/1/content/test/gpu/page_sets/gpu_rasterization_tests.py File content/test/gpu/page_sets/gpu_rasterization_tests.py (right): https://codereview.chromium.org/302003015/diff/1/content/test/gpu/page_sets/gpu_rasterization_tests.py#newcode14 content/test/gpu/page_sets/gpu_rasterization_tests.py:14: url='file://../../data/gpu/pixel_background.html', On 2014/06/02 23:20:14, Ken Russell wrote: > I'd ...
6 years, 6 months ago (2014-06-02 23:44:03 UTC) #3
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 6 months ago (2014-06-02 23:45:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/302003015/1
6 years, 6 months ago (2014-06-02 23:47:34 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 11:54:22 UTC) #6
Message was sent while issue was closed.
Change committed as 274469

Powered by Google App Engine
This is Rietveld 408576698