chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc - Issue 302003013: [SyncFS] Run V2 backend tasks as SyncTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc

Issue 302003013: [SyncFS] Run V2 backend tasks as SyncTask (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc

index a21d225bed679abfb975a292e6a15e410113a2a8..dd93f7dcafd6721afbafe736d8c838f6046da3b7 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc

@@ -328,7 +328,8 @@ void MetadataDatabaseIndex::AddToPathIndexes(

trackers_by_parent_and_title_[parent][title].Insert(new_tracker);

- if (trackers_by_parent_and_title_[parent][title].size() > 1) {

+ if (trackers_by_parent_and_title_[parent][title].size() > 1 &&

+ !title.empty()) {

DVLOG_IF(3, !ContainsKey(multi_backing_file_paths_,

ParentIDAndTitle(parent, title)))

<< " Add to multi_backing_file_paths_: " << parent << " " << title;

@@ -369,15 +370,17 @@ void MetadataDatabaseIndex::UpdateInPathIndexes(

(*trackers_by_title)[title].Insert(new_tracker);

- if (trackers_by_parent_and_title_[parent][old_title].size() <= 1) {

+ if (trackers_by_parent_and_title_[parent][old_title].size() <= 1 &&

+ !old_title.empty()) {

DVLOG_IF(3, ContainsKey(multi_backing_file_paths_,

- ParentIDAndTitle(parent, title)))

+ ParentIDAndTitle(parent, old_title)))

<< " Remove from multi_backing_file_paths_: "

- << parent << " " << title;

- multi_backing_file_paths_.erase(ParentIDAndTitle(parent, title));

+ << parent << " " << old_title;

+ multi_backing_file_paths_.erase(ParentIDAndTitle(parent, old_title));

}

- if (trackers_by_parent_and_title_[parent][title].size() > 1) {

+ if (trackers_by_parent_and_title_[parent][title].size() > 1 &&

+ !title.empty()) {

DVLOG_IF(3, !ContainsKey(multi_backing_file_paths_,

ParentIDAndTitle(parent, title)))

<< " Add to multi_backing_file_paths_: " << parent << " " << title;

@@ -407,7 +410,8 @@ void MetadataDatabaseIndex::RemoveFromPathIndexes(

trackers_by_parent_and_title_[parent][title].Erase(tracker_id);

- if (trackers_by_parent_and_title_[parent][title].size() <= 1) {

+ if (trackers_by_parent_and_title_[parent][title].size() <= 1 &&

+ !title.empty()) {

DVLOG_IF(3, ContainsKey(multi_backing_file_paths_,

ParentIDAndTitle(parent, title)))

<< " Remove from multi_backing_file_paths_: "