tools/telemetry/telemetry/core/backends/chrome/oobe.py - Issue 302003005: Also wait for gaia document.readyState to be complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/oobe.py

Issue 302003005: Also wait for gaia document.readyState to be complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/oobe.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/oobe.py b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

index d19a7cc615737ccd9544dc890c95034f3f488a13..9ca8ed3263b5a3c9d70518491b7ace6c6a619db9 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/oobe.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

@@ -16,7 +16,9 @@ class Oobe(web_contents.WebContents):

for gaia_context in range(15):

try:

if self.EvaluateJavaScriptInContext(

- "document.getElementById('Email') != null", gaia_context):

+ "document.readyState == 'complete' && "

+ "document.getElementById('Email') != null",

+ gaia_context):

return gaia_context

except exceptions.EvaluateException:

pass

« no previous file with comments | « no previous file | no next file » | no next file with comments »