Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issue 302003004: cc: Add HasPendingNotification to delayed unique notifier. (Closed)

Created:
6 years, 6 months ago by vmpstr
Modified:
6 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Add HasPendingNotification to delayed unique notifier. It would be nice to know if a notification is pending, so this patch adds this ability. This would be used in RenewTreePriority to detect whether we should be in smoothness mode or same priority mode. That is, if we have an expiration from smoothness pending, then we should still be in smoothness mode. R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273780

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M cc/base/delayed_unique_notifier.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/base/delayed_unique_notifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/base/delayed_unique_notifier_unittest.cc View 1 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vmpstr
Please take a look.
6 years, 6 months ago (2014-05-29 22:58:21 UTC) #1
reveman
lgtm with one small test request https://codereview.chromium.org/302003004/diff/1/cc/base/delayed_unique_notifier_unittest.cc File cc/base/delayed_unique_notifier_unittest.cc (right): https://codereview.chromium.org/302003004/diff/1/cc/base/delayed_unique_notifier_unittest.cc#newcode247 cc/base/delayed_unique_notifier_unittest.cc:247: notifier.Cancel(); While here, ...
6 years, 6 months ago (2014-05-30 00:19:28 UTC) #2
vmpstr
https://codereview.chromium.org/302003004/diff/1/cc/base/delayed_unique_notifier_unittest.cc File cc/base/delayed_unique_notifier_unittest.cc (right): https://codereview.chromium.org/302003004/diff/1/cc/base/delayed_unique_notifier_unittest.cc#newcode247 cc/base/delayed_unique_notifier_unittest.cc:247: notifier.Cancel(); On 2014/05/30 00:19:28, reveman wrote: > While here, ...
6 years, 6 months ago (2014-05-30 00:38:33 UTC) #3
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 6 months ago (2014-05-30 00:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/302003004/20001
6 years, 6 months ago (2014-05-30 00:40:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:08:06 UTC) #6
Message was sent while issue was closed.
Change committed as 273780

Powered by Google App Engine
This is Rietveld 408576698