Move tests for the layout test plugin to the right fixture.

Move tests for the layout test plugin to the right fixture.

BUG=30702
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52669

[jochen, 2010-07-16 07:33:55]

This test fails on my on a fresh build of Chrome w/o patches on Windows.

When you open the inspector while waiting for the timeout, you see the error
message

Uncaught TypeError: Object #<an HTMLEmbedElement> has no method 'getURL' 
self_delete_plugin_geturl.html:13

also it looks like chrome couldn't find a plugin to load (although the test
plugin is present and enabled).

Since in cases where this test fails on me, the other self delete plugin is
always also failing, I've not created a new bug report for it.

[Bernhard Bauer, 2010-07-16 09:42:56]

On 2010/07/16 07:33:55, jochen wrote:
> This test fails on my on a fresh build of Chrome w/o patches on Windows.
> 
> When you open the inspector while waiting for the timeout, you see the error
> message
> 
> Uncaught TypeError: Object #<an HTMLEmbedElement> has no method 'getURL' 
> self_delete_plugin_geturl.html:13
> 
> also it looks like chrome couldn't find a plugin to load (although the test
> plugin is present and enabled).
> 
> Since in cases where this test fails on me, the other self delete plugin is
> always also failing, I've not created a new bug report for it.

LGTM.

[jochen, 2010-07-16 11:09:16]

I had a closer look at it and it turns out these tests cannot ever work, because
they're testing the layout test plugin, but are executed with the npapi test
plugin.

i moved the respective tests to the right file.

the reason this works on the bot appears to be that plugin files do not get
deleted correctly, so old plugins hanging around make the test go green.

[Bernhard Bauer, 2010-07-16 11:58:38]

On 2010/07/16 11:09:16, jochen wrote:
> I had a closer look at it and it turns out these tests cannot ever work,
because
> they're testing the layout test plugin, but are executed with the npapi test
> plugin.
> 
> i moved the respective tests to the right file.
> 
> the reason this works on the bot appears to be that plugin files do not get
> deleted correctly, so old plugins hanging around make the test go green.

L even better TM.

[jochen, 2010-07-16 14:14:37]

Evan, seems on Linux, the trybots can't load the layout plugin (the error is
that the plugin is compiled for the wrong architecture)?

[Evan Martin, 2010-07-16 14:49:50]

I didn't change this code recently -- why'd it break?

[jochen, 2010-07-16 14:57:19]

On 2010/07/16 14:14:37, jochen wrote:
> Evan, seems on Linux, the trybots can't load the layout plugin (the error is
> that the plugin is compiled for the wrong architecture)?

so actually it loads, but it's a nacl plugin on linux?

[jochen, 2010-07-16 15:40:11]

ok, when i compile statically on linux, it works. i've marked the
selfdeleteplugin test as flaky for now, because it doesn't work on linux
(shlib). I check on monday whether after r52657 this problem is fixed and enable
it again.