Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: Source/core/inspector/InspectorCanvasAgent.cpp

Issue 301983003: Make Inspector aware of RemoteFrames in FrameTree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed a cast problem Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorCanvasAgent.cpp
diff --git a/Source/core/inspector/InspectorCanvasAgent.cpp b/Source/core/inspector/InspectorCanvasAgent.cpp
index 08664a6f0b6ce2186b792fe0e5582463fffe2154..015068de8a9fb794f8034e243d4a19a792ece3bc 100644
--- a/Source/core/inspector/InspectorCanvasAgent.cpp
+++ b/Source/core/inspector/InspectorCanvasAgent.cpp
@@ -310,18 +310,20 @@ void InspectorCanvasAgent::didCommitLoad(LocalFrame*, DocumentLoader* loader)
{
if (!m_enabled)
return;
- LocalFrame* frame = loader->frame();
+ Frame* frame = loader->frame();
if (frame == m_pageAgent->mainFrame()) {
for (FramesWithUninstrumentedCanvases::iterator it = m_framesWithUninstrumentedCanvases.begin(); it != m_framesWithUninstrumentedCanvases.end(); ++it)
it->value = false;
m_frontend->traceLogsRemoved(0, 0);
} else {
while (frame) {
- if (m_framesWithUninstrumentedCanvases.contains(frame))
- m_framesWithUninstrumentedCanvases.set(frame, false);
- if (m_pageAgent->hasIdForFrame(frame)) {
- String frameId = m_pageAgent->frameId(frame);
- m_frontend->traceLogsRemoved(&frameId, 0);
+ if (frame->isLocalFrame()) {
+ if (m_framesWithUninstrumentedCanvases.contains(toLocalFrame(frame)))
yurys 2014/06/02 07:56:27 Please extract toLocalFrame(frame) into a variable
kenrb 2014/06/02 15:20:48 Done.
+ m_framesWithUninstrumentedCanvases.set(toLocalFrame(frame), false);
+ if (m_pageAgent->hasIdForFrame(toLocalFrame(frame))) {
+ String frameId = m_pageAgent->frameId(toLocalFrame(frame));
+ m_frontend->traceLogsRemoved(&frameId, 0);
+ }
}
frame = frame->tree().traverseNext();
}

Powered by Google App Engine
This is Rietveld 408576698