Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/read_file.h

Issue 301973007: [fsp] Fix crash when reading files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_
6 #define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_ 6 #define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_
7 7
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/chromeos/file_system_provider/operations/operation.h" 11 #include "chrome/browser/chromeos/file_system_provider/operations/operation.h"
11 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_info .h" 12 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_info .h"
12 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_inte rface.h" 13 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_inte rface.h"
13 #include "chrome/browser/chromeos/file_system_provider/request_value.h" 14 #include "chrome/browser/chromeos/file_system_provider/request_value.h"
14 #include "net/base/io_buffer.h" 15 #include "net/base/io_buffer.h"
15 #include "webkit/browser/fileapi/async_file_util.h" 16 #include "webkit/browser/fileapi/async_file_util.h"
16 17
17 namespace base { 18 namespace base {
18 class FilePath; 19 class FilePath;
19 } // namespace base 20 } // namespace base
20 21
21 namespace extensions { 22 namespace extensions {
22 class EventRouter; 23 class EventRouter;
23 } // namespace extensions 24 } // namespace extensions
24 25
25 namespace chromeos { 26 namespace chromeos {
26 namespace file_system_provider { 27 namespace file_system_provider {
27 namespace operations { 28 namespace operations {
28 29
29 // Bridge between fileapi read file and providing extension's read fil request. 30 // Bridge between fileapi read file and providing extension's read fil request.
30 // Created per request. 31 // Created per request.
31 class ReadFile : public Operation { 32 class ReadFile : public Operation {
32 public: 33 public:
33 ReadFile( 34 ReadFile(
34 extensions::EventRouter* event_router, 35 extensions::EventRouter* event_router,
35 const ProvidedFileSystemInfo& file_system_info, 36 const ProvidedFileSystemInfo& file_system_info,
36 int file_handle, 37 int file_handle,
37 net::IOBuffer* buffer, 38 scoped_refptr<net::IOBuffer> buffer,
38 int64 offset, 39 int64 offset,
39 int length, 40 int length,
40 const ProvidedFileSystemInterface::ReadChunkReceivedCallback& callback); 41 const ProvidedFileSystemInterface::ReadChunkReceivedCallback& callback);
41 virtual ~ReadFile(); 42 virtual ~ReadFile();
42 43
43 // Operation overrides. 44 // Operation overrides.
44 virtual bool Execute(int request_id) OVERRIDE; 45 virtual bool Execute(int request_id) OVERRIDE;
45 virtual void OnSuccess(int request_id, 46 virtual void OnSuccess(int request_id,
46 scoped_ptr<RequestValue> result, 47 scoped_ptr<RequestValue> result,
47 bool has_next) OVERRIDE; 48 bool has_next) OVERRIDE;
48 virtual void OnError(int request_id, base::File::Error error) OVERRIDE; 49 virtual void OnError(int request_id, base::File::Error error) OVERRIDE;
49 50
50 private: 51 private:
51 int file_handle_; 52 int file_handle_;
52 net::IOBuffer* buffer_; 53 scoped_refptr<net::IOBuffer> buffer_;
53 int64 offset_; 54 int64 offset_;
54 int length_; 55 int length_;
55 int64 current_offset_; 56 int64 current_offset_;
56 const ProvidedFileSystemInterface::ReadChunkReceivedCallback callback_; 57 const ProvidedFileSystemInterface::ReadChunkReceivedCallback callback_;
57 58
58 DISALLOW_COPY_AND_ASSIGN(ReadFile); 59 DISALLOW_COPY_AND_ASSIGN(ReadFile);
59 }; 60 };
60 61
61 } // namespace operations 62 } // namespace operations
62 } // namespace file_system_provider 63 } // namespace file_system_provider
63 } // namespace chromeos 64 } // namespace chromeos
64 65
65 #endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_ 66 #endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_READ_FILE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698