Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 301973006: Move frame_to_announce to be assigned later in CreateRenderFrame. (Closed)

Created:
6 years, 6 months ago by nasko
Modified:
6 years, 6 months ago
Reviewers:
ncarter (slow), jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Move frame_to_announce to be assigned later in CreateRenderFrame. We shouldn't be dispatching RenderFrameCreated for swapped out frames. BUG=378889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Hey John, Can you review this CL for me? Nick is out for today and ...
6 years, 6 months ago (2014-05-29 22:39:07 UTC) #1
jam
lgtm
6 years, 6 months ago (2014-05-29 23:25:49 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 6 months ago (2014-05-29 23:32:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/301973006/1
6 years, 6 months ago (2014-05-29 23:37:23 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 08:15:26 UTC) #5
Message was sent while issue was closed.
Change committed as 273764

Powered by Google App Engine
This is Rietveld 408576698