Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Unified Diff: chrome/browser/service_process/service_process_control.cc

Issue 301973003: Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/service_process/service_process_control.cc
diff --git a/chrome/browser/service_process/service_process_control.cc b/chrome/browser/service_process/service_process_control.cc
index b9cfa5714646323fd7f7b646fcbe501e351cb90e..c708562cda6838f2faecfb41e143a2a741c6f85f 100644
--- a/chrome/browser/service_process/service_process_control.cc
+++ b/chrome/browser/service_process/service_process_control.cc
@@ -51,15 +51,14 @@ void ServiceProcessControl::ConnectInternal() {
// TODO(hclam): Handle error connecting to channel.
const IPC::ChannelHandle channel_id = GetServiceProcessChannel();
- SetChannel(new IPC::ChannelProxy(
+ SetChannel(IPC::ChannelProxy::CreateClient(
channel_id,
- IPC::Channel::MODE_NAMED_CLIENT,
this,
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO).get()));
}
-void ServiceProcessControl::SetChannel(IPC::ChannelProxy* channel) {
- channel_.reset(channel);
+void ServiceProcessControl::SetChannel(scoped_ptr<IPC::ChannelProxy> channel) {
+ channel_ = channel.Pass();
}
void ServiceProcessControl::RunConnectDoneTasks() {

Powered by Google App Engine
This is Rietveld 408576698