Support Bluetooth network connection type on Android.

Support Bluetooth network connection type on Android.

BUG=378785
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274901

[jkarlin, 2014-06-02 13:47:30]

pauljensen: Please review everything.

[pauljensen, 2014-06-02 13:52:20]

I defer to Philippe, a more specific net/android/ owner.

[Philippe, 2014-06-02 14:01:02]

Does this piece need to land in a CL other than
https://codereview.chromium.org/307943004/?

[pauljensen, 2014-06-02 14:04:28]

On 2014/06/02 14:01:02, Philippe wrote:
> Does this piece need to land in a CL other than
> https://codereview.chromium.org/307943004/

I don't think it needs to but I think it's a good idea to separate larger
changes into smaller pieces when possible.

[Philippe, 2014-06-02 14:11:45]

On 2014/06/02 14:04:28, pauljensen wrote:
> On 2014/06/02 14:01:02, Philippe wrote:
> > Does this piece need to land in a CL other than
> > https://codereview.chromium.org/307943004/
> 
> I don't think it needs to but I think it's a good idea to separate larger
> changes into smaller pieces when possible.

Yes, this is also true. My initial reaction was that 307943004 could have landed
in a single atomic piece (that can also be easily reverted in case it needs to)
given that this CL is very small and needed for the former I assume but I'm also
OK with proceeding this way.

LGTM.

[pauljensen, 2014-06-02 14:16:26]

On 2014/06/02 14:11:45, Philippe wrote:
> On 2014/06/02 14:04:28, pauljensen wrote:
> > On 2014/06/02 14:01:02, Philippe wrote:
> > > Does this piece need to land in a CL other than
> > > https://codereview.chromium.org/307943004/
> > 
> > I don't think it needs to but I think it's a good idea to separate larger
> > changes into smaller pieces when possible.
> 
> Yes, this is also true. My initial reaction was that 307943004 could have
landed
> in a single atomic piece (that can also be easily reverted in case it needs
to)
> given that this CL is very small and needed for the former I assume but I'm
also
> OK with proceeding this way.
> 
> LGTM.

I do not believe this CL is needed for 307943004, in other words I don't believe
307943004 not dependent on this CL.

[pauljensen, 2014-06-02 14:16:57]

On 2014/06/02 14:16:26, pauljensen wrote:
> On 2014/06/02 14:11:45, Philippe wrote:
> > On 2014/06/02 14:04:28, pauljensen wrote:
> > > On 2014/06/02 14:01:02, Philippe wrote:
> > > > Does this piece need to land in a CL other than
> > > > https://codereview.chromium.org/307943004/
> > > 
> > > I don't think it needs to but I think it's a good idea to separate larger
> > > changes into smaller pieces when possible.
> > 
> > Yes, this is also true. My initial reaction was that 307943004 could have
> landed
> > in a single atomic piece (that can also be easily reverted in case it needs
> to)
> > given that this CL is very small and needed for the former I assume but I'm
> also
> > OK with proceeding this way.
> > 
> > LGTM.
> 
> I do not believe this CL is needed for 307943004, in other words I don't
believe
> 307943004 not dependent on this CL.

Typo: I do not believe this CL is needed for 307943004, in other words I don't
believe
307943004 is dependent on this CL.

[Philippe, 2014-06-02 14:17:59]

On 2014/06/02 14:16:57, pauljensen wrote:
> On 2014/06/02 14:16:26, pauljensen wrote:
> > On 2014/06/02 14:11:45, Philippe wrote:
> > > On 2014/06/02 14:04:28, pauljensen wrote:
> > > > On 2014/06/02 14:01:02, Philippe wrote:
> > > > > Does this piece need to land in a CL other than
> > > > > https://codereview.chromium.org/307943004/
> > > > 
> > > > I don't think it needs to but I think it's a good idea to separate
larger
> > > > changes into smaller pieces when possible.
> > > 
> > > Yes, this is also true. My initial reaction was that 307943004 could have
> > landed
> > > in a single atomic piece (that can also be easily reverted in case it
needs
> > to)
> > > given that this CL is very small and needed for the former I assume but
I'm
> > also
> > > OK with proceeding this way.
> > > 
> > > LGTM.
> > 
> > I do not believe this CL is needed for 307943004, in other words I don't
> believe
> > 307943004 not dependent on this CL.
> 
> Typo: I do not believe this CL is needed for 307943004, in other words I don't
> believe
> 307943004 is dependent on this CL.

Ok, thanks Paul for the clarification :)

[jkarlin, 2014-06-02 14:34:17]

On 2014/06/02 14:17:59, Philippe wrote:
> On 2014/06/02 14:16:57, pauljensen wrote:
> > On 2014/06/02 14:16:26, pauljensen wrote:
> > > On 2014/06/02 14:11:45, Philippe wrote:
> > > > On 2014/06/02 14:04:28, pauljensen wrote:
> > > > > On 2014/06/02 14:01:02, Philippe wrote:
> > > > > > Does this piece need to land in a CL other than
> > > > > > https://codereview.chromium.org/307943004/
> > > > > 
> > > > > I don't think it needs to but I think it's a good idea to separate
> larger
> > > > > changes into smaller pieces when possible.
> > > > 
> > > > Yes, this is also true. My initial reaction was that 307943004 could
have
> > > landed
> > > > in a single atomic piece (that can also be easily reverted in case it
> needs
> > > to)
> > > > given that this CL is very small and needed for the former I assume but
> I'm
> > > also
> > > > OK with proceeding this way.
> > > > 
> > > > LGTM.
> > > 
> > > I do not believe this CL is needed for 307943004, in other words I don't
> > believe
> > > 307943004 not dependent on this CL.
> > 
> > Typo: I do not believe this CL is needed for 307943004, in other words I
don't
> > believe
> > 307943004 is dependent on this CL.
> 
> Ok, thanks Paul for the clarification :)

That's correct, this CL depends on http://crrev.com/307943004 but not the other
way around.  I separated the ChromeOS and Android support for bluetooth into
separate CLs to make all three CLs easier to review.  Thanks Paul and Philippe.

[jkarlin, 2014-06-04 14:10:18]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-06-04 14:11:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/301973002/20001

[commit-bot: I haz the power, 2014-06-04 20:47:11]

Change committed as 274901