Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 301943002: Files.app: Omit first draw without metadata in file list (Closed)

Created:
6 years, 6 months ago by yoshiki
Modified:
6 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Files.app: Omit first draw without metadata in file list Before this patch, Files.app was draw the filelist twice. 1) After fetching list of file entry, draw the list without metadata. 2) After fetching the metadata, draw the list with metadata. This way was because the metadata fetch had been slow, so we drew the list without metadata at the first time. But this took long time in total since drawing was twice (). And sometimes #2 was not happen and caused the issue since #2 was triggered by sort. Now fetching metadata is enough fast, and we can combine them. This patch omit the first draw #1. This improves the performance, and fixes crbug.com/375575. BUG=375575, 367123 TEST=filelist was drawn correctly R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275808

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoshiki
@mtomasz: PTAL. Thanks.
6 years, 6 months ago (2014-05-30 04:24:18 UTC) #1
mtomasz
lgtm
6 years, 6 months ago (2014-05-30 05:27:47 UTC) #2
yoshiki
Thanks!
6 years, 6 months ago (2014-05-30 05:32:31 UTC) #3
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 6 months ago (2014-05-30 05:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/301943002/20001
6 years, 6 months ago (2014-05-30 05:34:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 10:27:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 11:56:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/32620)
6 years, 6 months ago (2014-05-30 11:56:52 UTC) #8
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 6 months ago (2014-06-09 11:33:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/301943002/40001
6 years, 6 months ago (2014-06-09 11:34:47 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 12:58:23 UTC) #11
yoshiki
6 years, 6 months ago (2014-06-09 15:01:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r275808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698