Changing default_url to destination_url for consistency

Changing default_url to destination_url for consistency

At most of the places default_url was changed to destination_url, however, it was missed at some places.
This patch changes the remaining default_url(s) to destination_url.

BUG=378737
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274497

[amogh.bihani, 2014-05-29 12:45:17]

As discussed in https://codereview.chromium.org/297703002/#msg5
I have changed the default_urls to destination_url.

Also I logged bug 378737 for it. I thought it might be useful for discussion if
required.

PTAL.

[amogh.bihani, 2014-05-29 13:00:31]

https://codereview.chromium.org/301933002/diff/1/content/renderer/pepper/cont...
File content/renderer/pepper/content_decryptor_delegate.h (right):

https://codereview.chromium.org/301933002/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.h:91: PP_Var
destination_url_var);
This is to make it consistant with its .cc file.
argument names were different in .h and .cc file.

https://codereview.chromium.org/301933002/diff/1/media/cdm/ppapi/cdm_adapter.cc
File media/cdm/ppapi/cdm_adapter.cc (right):

https://codereview.chromium.org/301933002/diff/1/media/cdm/ppapi/cdm_adapter....
media/cdm/ppapi/cdm_adapter.cc:588: const std::string& destination_url) {
I have intentionally not changed this string to GURL as in the very next step,
ContentDecryptor_Private will convert it to pp::Var. There we will have to
change it back to string.
So it seems unnecessary to change it to GURL for just one step.

[xhwang, 2014-05-29 16:17:44]

looking pretty good. just one question.

https://codereview.chromium.org/301933002/diff/1/content/renderer/media/webme...
File content/renderer/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/301933002/diff/1/content/renderer/media/webme...
content/renderer/media/webmediaplayer_impl.cc:1106: << "Invalid URL in
destination_url: " << destination_url.spec();
Since we verified |destination_url| upstream (in the last CL), can we actually
DCHECK here that the url is either empty or valid?

[amogh.bihani, 2014-05-30 03:17:02]

On 2014/05/29 16:17:44, xhwang wrote:
> looking pretty good. just one question.
> 
>
https://codereview.chromium.org/301933002/diff/1/content/renderer/media/webme...
> File content/renderer/media/webmediaplayer_impl.cc (right):
> 
>
https://codereview.chromium.org/301933002/diff/1/content/renderer/media/webme...
> content/renderer/media/webmediaplayer_impl.cc:1106: << "Invalid URL in
> destination_url: " << destination_url.spec();
> Since we verified |destination_url| upstream (in the last CL), can we actually
> DCHECK here that the url is either empty or valid?

Thanks :)
I have made the change.

[xhwang, 2014-05-30 05:09:46]

Thanks! LGTM

[amogh.bihani, 2014-05-30 05:15:57]

On 2014/05/30 05:09:46, xhwang wrote:
> Thanks! LGTM

+r teravest@ for ppapi/ and content/renderer/pepper/

[amogh.bihani, 2014-06-02 06:39:49]

teravest@
OWNER's review please. :)

[teravest, 2014-06-02 14:25:33]

pepper and ppapi look good, but there's something weird in
content/renderer/media...

https://codereview.chromium.org/301933002/diff/20001/content/renderer/media/w...
File content/renderer/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/301933002/diff/20001/content/renderer/media/w...
content/renderer/media/webmediaplayer_impl.cc:1105:
DCHECK(destination_url.is_empty() || destination_url.is_valid());
This should be !destination_url.is_valid(), right?

[AmoghBihani, 2014-06-02 16:23:51]

https://codereview.chromium.org/301933002/diff/20001/content/renderer/media/w...
File content/renderer/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/301933002/diff/20001/content/renderer/media/w...
content/renderer/media/webmediaplayer_impl.cc:1105:
DCHECK(destination_url.is_empty() || destination_url.is_valid());
On 2014/06/02 14:25:34, teravest wrote:
> This should be !destination_url.is_valid(), right?

We want the URL to be either empty or valid. This is a negation of the earlier
code where we sent a warning when the URL was neither empty not valid, i.e.
filled with invalid characters.

[teravest, 2014-06-02 16:24:49]

lgtm

[amogh.bihani, 2014-06-03 04:17:36]

The CQ bit was checked by amogh.bihani@samsung.com

[commit-bot: I haz the power, 2014-06-03 04:19:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/301933002/20001

[amogh.bihani, 2014-06-03 05:04:11]

The CQ bit was unchecked by amogh.bihani@samsung.com

[amogh.bihani, 2014-06-03 05:49:21]

The CQ bit was checked by amogh.bihani@samsung.com

[commit-bot: I haz the power, 2014-06-03 05:50:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/301933002/80001

[commit-bot: I haz the power, 2014-06-03 10:01:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 13:07:51]

Change committed as 274497