Issue 301923002: Revert of Follow up change for disabling out-of-box VK overscroll

Issue 301923002: Revert of Follow up change for disabling out-of-box VK overscroll (Closed)

Created:
6 years, 6 months ago by tzik

Modified:
6 years, 6 months ago

Reviewers:
Nikita (slow), ygorshenin1

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Follow up change for disabling out-of-box VK overscroll (https://codereview.chromium.org/298373002/) Reason for revert: This CL broke VMTest on ChromiumOS bot: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999 http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/21999/steps/VMTest%20%28attempt%201%29/logs/stdio Original issue's description: > Follow up change for disabling out-of-box VK overscroll > > Have to use CoreOobeActor through OobeUI since WebUILoginDisplay is not created during out-of-box. > Removed changes in *LoginDisplay*. > > BUG=363635 > R=ygorshenin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273241 TBR=ygorshenin@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=363635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273466

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -17 lines)			Patch
M	chrome/browser/chromeos/login/ui/login_display.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_display_host_impl.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/mock_login_display.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/oobe_display.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tzik

Created Revert of Follow up change for disabling out-of-box VK overscroll

6 years, 6 months ago (2014-05-29 09:34:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/301923002/1

6 years, 6 months ago (2014-05-29 09:36:53 UTC) #2

Nikita (slow)

This is not my CL, see https://code.google.com/p/chromium/issues/detail?id=378430

6 years, 6 months ago (2014-05-29 10:10:03 UTC) #4

tzik

On 2014/05/29 10:10:03, Nikita Kostylev wrote: > This is not my CL, see > https://code.google.com/p/chromium/issues/detail?id=378430 ...

6 years, 6 months ago (2014-05-29 10:19:09 UTC) #5

Nikita (slow)

6 years, 6 months ago (2014-05-29 14:10:48 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/301163002/ by nkostylev@chromium.org.

The reason for reverting is: Reverting incorrect revert.

Proper revert committed in
http://src.chromium.org/viewvc/chrome?view=rev&revision=273467.

Expand Messages | Collapse Messages