Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 3018613002: devil: Log output when forwarder has trouble exiting. (Closed)

Created:
3 years, 3 months ago by bpastene
Modified:
3 years, 2 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M devil/devil/android/forwarder.py View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 9 (4 generated)
bpastene
3 years, 3 months ago (2017-09-22 22:08:56 UTC) #2
jbudorick
lgtm w/ question that we can address in a follow-up CL if necessary. https://codereview.chromium.org/3018613002/diff/1/devil/devil/android/forwarder.py File ...
3 years, 2 months ago (2017-09-25 09:00:49 UTC) #3
bpastene
https://codereview.chromium.org/3018613002/diff/1/devil/devil/android/forwarder.py File devil/devil/android/forwarder.py (right): https://codereview.chromium.org/3018613002/diff/1/devil/devil/android/forwarder.py#newcode425 devil/devil/android/forwarder.py:425: raise HostForwarderError( On 2017/09/25 09:00:49, jbudorick wrote: > I ...
3 years, 2 months ago (2017-09-25 17:43:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3018613002/1
3 years, 2 months ago (2017-09-25 17:43:46 UTC) #6
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 18:16:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698