Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js

Issue 3018603002: Add tab.StopAllServiceWorkers() (Closed)
Patch Set: call ServiceWorker.enable on initializing InspectorServiceWorker Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js
diff --git a/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js b/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js
index 796d770cea28bfacf9d3c4d86100e88768c7f9c1..5f60dce70f62bbcc7afb7a6326975eb78feee98e 100644
--- a/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js
+++ b/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js
@@ -7,6 +7,10 @@
/**
* @fileoverview This file provides a JavaScript helper function that
* determines whether service worker registration has completed.
+ * After tracking service worker events and catching notifications are enabled
+ * (in InspectorServiceWorker._OnNotification), these ServiceWorker registration
+ * state should be operated there.
+ * TODO: move ServiceWorker state operations to InspectorServiceWorker
*/
(function() {
// Make executing this code idempotent.

Powered by Google App Engine
This is Rietveld 408576698