Add tab.StopAllServiceWorkers()

telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import functools
 import logging
 import socket
 import sys
 
 from py_trace_event import trace_event
 
 from telemetry.core import exceptions
 from telemetry import decorators
 from telemetry.internal.backends.chrome_inspector import devtools_http
 from telemetry.internal.backends.chrome_inspector import inspector_console
 from telemetry.internal.backends.chrome_inspector import inspector_memory
 from telemetry.internal.backends.chrome_inspector import inspector_page
 from telemetry.internal.backends.chrome_inspector import inspector_runtime
+from telemetry.internal.backends.chrome_inspector import inspector_serviceworker
 from telemetry.internal.backends.chrome_inspector import inspector_storage
 from telemetry.internal.backends.chrome_inspector import inspector_websocket
 from telemetry.internal.backends.chrome_inspector import websocket
 from telemetry.util import js_template
 
 import py_utils
 
 
 def _HandleInspectorWebSocketExceptions(func):
   """Decorator for converting inspector_websocket exceptions.
@@ skipping 36 matching lines @@
     self._context = context
 
     logging.debug('InspectorBackend._Connect() to %s', self.debugger_url)
     try:
       self._websocket.Connect(self.debugger_url, timeout)
       self._console = inspector_console.InspectorConsole(self._websocket)
       self._memory = inspector_memory.InspectorMemory(self._websocket)
       self._page = inspector_page.InspectorPage(
           self._websocket, timeout=timeout)
       self._runtime = inspector_runtime.InspectorRuntime(self._websocket)
+      self._serviceworker = inspector_serviceworker.InspectorServiceWorker(
+          self._websocket)
       self._storage = inspector_storage.InspectorStorage(self._websocket)
     except (websocket.WebSocketException, exceptions.TimeoutException,
             py_utils.TimeoutException) as e:
       self._ConvertExceptionFromInspectorWebsocket(e)
 
+    self._serviceworker.Enable(timeout)

[kouhei (in TOK), 2017/09/25 02:29:25]

This enables ServiceWorker backend for all InspectorBackends.
I think this is acceptable given its low overhead.

Would you note this behavioral change in CL desc?

[yukiy, 2017/09/25 04:57:13]

Done.

+
   def Disconnect(self):
     """Disconnects the inspector websocket.
 
     This method intentionally leaves the self._websocket object around, so that
     future calls it to it will fail with a relevant error.
     """
     if self._websocket:
       self._websocket.Disconnect()
 
   def __del__(self):
@@ skipping 13 matching lines @@
     return self._devtools_client.GetUrl(self.id)
 
   @property
   def id(self): # pylint: disable=invalid-name
     return self._context['id']
 
   @property
   def debugger_url(self):
     return self._context['webSocketDebuggerUrl']
 
+  def StopAllServiceWorkers(self, timeout):
+    self._serviceworker.StopAllWorkers(timeout)
+
   def ClearDataForOrigin(self, url, timeout):
     self._storage.ClearDataForOrigin(url, timeout)
 
   def GetWebviewInspectorBackends(self):
     """Returns a list of InspectorBackend instances associated with webviews.
 
     Raises:
       devtools_http.DevToolsClientConnectionError
     """
     inspector_backends = []
@@ skipping 384 matching lines @@
     error.AddDebuggingMessage(msg)
     error.AddDebuggingMessage('Debugger url: %s' % self.debugger_url)
 
   @_HandleInspectorWebSocketExceptions
   def _EvaluateJavaScript(self, expression, context_id, timeout):
     return self._runtime.Evaluate(expression, context_id, timeout)
 
   @_HandleInspectorWebSocketExceptions
   def CollectGarbage(self):
     self._page.CollectGarbage()