Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: systrace/systrace/tracing_agents/__init__.py

Issue 3018533002: Implementing a Monsoon power monitor trace agent, utilizing the UI infrastructure that the BattOr a…
Patch Set: Updating static methods and fixing test fakes. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright 2016 The Chromium Authors. All rights reserved. 3 # Copyright 2016 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 '''Tracing agent interface for systrace. 7 '''Tracing agent interface for systrace.
8 8
9 This class represents an agent that captures traces from a particular 9 This class represents an agent that captures traces from a particular
10 tool (e.g. atrace, ftrace.) 10 tool (e.g. atrace, ftrace.)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 StopAgentTracing is done. This function blocks until the result 82 StopAgentTracing is done. This function blocks until the result
83 is collected (note; this may take several seconds). Stops with timeout 83 is collected (note; this may take several seconds). Stops with timeout
84 if not completed within self._options.collection_timeout seconds. 84 if not completed within self._options.collection_timeout seconds.
85 85
86 Args: 86 Args:
87 timeout: Timeout interval in seconds. 87 timeout: Timeout interval in seconds.
88 Returns: 88 Returns:
89 Completed trace for this agent. 89 Completed trace for this agent.
90 ''' 90 '''
91 pass 91 pass
92
93 # pylint: disable=no-self-use
Zhen Wang 2017/09/28 01:58:48 Why do we need this pylint disable?
94 def IsConnectionOwner(self):
95 '''Find out of this tracing agent is also a connection owner.
96
97 Connection owners are handled specifically within the tracing controller, as
98 they may both disable and enable access to the device under test.
99 For example, a power monitoring tracing agent may disable the USB port to
Zhen Wang 2017/09/28 01:58:48 Please name Monsoon explicitly here. There is anot
100 improve power consumption accuracy.
101
Zhen Wang 2017/09/28 01:58:48 Can you also add that the connection owner will st
102 Returns:
103 Boolean value indicating whether this tracing agent is a connection
104 owner.
105 '''
106 return False
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698