Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py - Issue 301853003: Make update-flaky-tests to work again and support all bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

Issue 301853003: Make update-flaky-tests to work again and support all bots (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

index 75c0a661ac84537cb522915d86bea8af24990f2e..0c77183f0511110d333abb0455cfb47b5190ce07 100644

--- a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -402,7 +402,7 @@ class TestExpectationLine(object):

and self.is_skipped_outside_expectations_file == other.is_skipped_outside_expectations_file)

def is_invalid(self):

- return self.warnings and self.warnings != [TestExpectationParser.MISSING_BUG_WARNING]

+ return bool(self.warnings and self.warnings != [TestExpectationParser.MISSING_BUG_WARNING])

Dirk Pranke 2014/05/29 18:25:21 why was this needed?

def is_flaky(self):

return len(self.parsed_expectations) > 1