Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py - Issue 301853003: Make update-flaky-tests to work again and support all bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

Issue 301853003: Make update-flaky-tests to work again and support all bots (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed use of operator.attrgetter Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py ('k') | Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | Tools/Scripts/webkitpy/tool/commands/flakytests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

index 1456d5f17723b6c1c752a933dd980a5648f7ad54..a95352398d11ea833a543010dbbcb5944cbb36d5 100644

--- a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

+++ b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

@@ -42,7 +42,7 @@ class BotTestExpectationsTest(unittest.TestCase):

def _assert_is_flaky(self, results_string, should_be_flaky):

results_json = self._results_json_from_test_data({})

- expectations = bot_test_expectations.BotTestExpectations(results_json)

+ expectations = bot_test_expectations.BotTestExpectations(results_json, set('test'))

length_encoded = self._results_from_string(results_string)['results']

num_actual_results = len(expectations._flaky_types_in_results(length_encoded, only_ignore_very_flaky=True))

if should_be_flaky:

@@ -80,12 +80,12 @@ class BotTestExpectationsTest(unittest.TestCase):

def _assert_expectations(self, test_data, expectations_string, only_ignore_very_flaky):

results_json = self._results_json_from_test_data(test_data)

- expectations = bot_test_expectations.BotTestExpectations(results_json)

+ expectations = bot_test_expectations.BotTestExpectations(results_json, set('test'))

self.assertEqual(expectations.flakes_by_path(only_ignore_very_flaky), expectations_string)

def _assert_unexpected_results(self, test_data, expectations_string):

results_json = self._results_json_from_test_data(test_data)

- expectations = bot_test_expectations.BotTestExpectations(results_json)

+ expectations = bot_test_expectations.BotTestExpectations(results_json, set('test'))

self.assertEqual(expectations.unexpected_results_by_path(), expectations_string)

def test_basic(self):