Fix telemetry's IsBrowserRunning check

telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import subprocess
 
 from telemetry.core import exceptions
 from telemetry.internal.platform import android_platform_backend as \
   android_platform_backend_module
@@ skipping 249 matching lines @@
 
     self._StopBrowser()
 
     self.platform_backend.StopForwardingHost(self._port)
 
     if self._output_profile_path:
       self.platform_backend.PullProfile(
           self._backend_settings.package, self._output_profile_path)
 
   def IsBrowserRunning(self):
-    return self.platform_backend.IsAppRunning(self._backend_settings.package)
+    return self.platform_backend.IsAppRunning(
+        '%s$' % (self._backend_settings.package))

[perezju, 2017/09/19 12:57:01]

I don't think this will work. The process name is not matched as a regex.

The fix should be done in IsAppRunning [1], probably replacing the call from
GetPids to GetApplicationPids [2].

This change should be safe, but please also check with other callers of
IsAppRunning whether this isn't likely to break their expectations.

[1]:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

[2]:
https://cs.chromium.org/chromium/src/third_party/catapult/devil/devil/android...

[bokan, 2017/09/25 19:53:32]

D'oh! Sorry, you're right, I missed what `-F` does in grep (I thought I tried it
for both running and not-running but I must have been sloppy).

Thanks for the solution. I've made the change and confirmed it fixes the issue.
It also seems that this is the only user of PlatformBackend.IsAppRunning
(https://cs.chromium.org/search/?q=IsAppRunning+file:.*.py$&sq=package:chromiu...)
 

 
   def GetStandardOutput(self):
     return self.platform_backend.GetStandardOutput()
 
   def GetStackTrace(self):
     return self.platform_backend.GetStackTrace()
 
   def GetMostRecentMinidumpPath(self):
     return None
 
   def GetAllMinidumpPaths(self):
     return None
 
   def GetAllUnsymbolizedMinidumpPaths(self):
     return None
 
   def SymbolizeMinidump(self, minidump_path):
     return None