Store repaint rects in the coordinate space of their backing GraphicsLayer.

Source/core/rendering/RenderLayerRepainter.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 188 matching lines @@
         absRect.moveBy(delta);
 
         if (absRect.isEmpty())
             return;
 
         RenderView* view = m_renderer.view();
         if (view)
             view->repaintViewRectangle(absRect);
         return;
     }
-    if (m_renderer.compositingState() == PaintsIntoGroupedBacking) {
-        LayoutRect updatedRect(r);
-
-        ASSERT(m_renderer.layer());
-        ASSERT(m_renderer.layer()->enclosingTransformedAncestor());
-        ASSERT(m_renderer.layer()->enclosingTransformedAncestor()->renderer());
-
-        // FIXME: this defensive code should not have to exist. None of these pointers should ever be 0. See crbug.com/370410.
-        RenderLayerModelObject* transformedAncestor = 0;
-        if (RenderLayer* ancestor = m_renderer.layer()->enclosingTransformedAncestor())
-            transformedAncestor = ancestor->renderer();
-        if (!transformedAncestor)
-            return;
-
-        // If the transformedAncestor is actually the RenderView, we might get
-        // confused and think that we can use LayoutState. Ideally, we'd made
-        // LayoutState work for all composited layers as well, but until then
-        // we need to disable LayoutState for squashed layers.
-        LayoutStateDisabler layoutStateDisabler(*transformedAncestor);
-
-        // This code adjusts the repaint rectangle to be in the space of the transformed ancestor of the grouped (i.e. squashed)
-        // layer. This is because all layers that squash together need to repaint w.r.t. a single container that is
-        // an ancestor of all of them, in order to properly take into account any local transforms etc.
-        // FIXME: remove this special-case code that works around the repainting code structure.
-        m_renderer.computeRectForRepaint(transformedAncestor, updatedRect);
-        updatedRect.moveBy(-m_renderer.layer()->groupedMapping()->squashingOffsetFromTransformedAncestor());
-
-        IntRect repaintRect = pixelSnappedIntRect(updatedRect);
+    IntRect repaintRect = pixelSnappedIntRect(r);
+    // FIXME: generalize accessors to backing GraphicsLayers so that this code is squashing-agnostic.
+    if (m_renderer.groupedMapping()) {
         if (GraphicsLayer* squashingLayer = m_renderer.groupedMapping()->squashingLayer())
             squashingLayer->setNeedsDisplayInRect(repaintRect);
     } else {
-        IntRect repaintRect = pixelSnappedIntRect(r);
         m_renderer.compositedLayerMapping()->setContentsNeedDisplayInRect(repaintRect);
     }
 }
 
 void RenderLayerRepainter::setFilterBackendNeedsRepaintingInRect(const LayoutRect& rect)
 {
     if (rect.isEmpty())
         return;
-
     LayoutRect rectForRepaint = rect;
     m_renderer.style()->filterOutsets().expandRect(rectForRepaint);
 
     RenderLayerFilterInfo* filterInfo = m_renderer.layer()->filterInfo();
     ASSERT(filterInfo);
     filterInfo->expandDirtySourceRect(rectForRepaint);
 
     RenderLayer* parentLayer = enclosingFilterRepaintLayer();
     ASSERT(parentLayer);
     FloatQuad repaintQuad(rectForRepaint);
@@ skipping 24 matching lines @@
 RenderLayer* RenderLayerRepainter::enclosingFilterRepaintLayer() const
 {
     for (const RenderLayer* curr = m_renderer.layer(); curr; curr = curr->parent()) {
         if ((curr != m_renderer.layer() && curr->requiresFullLayerImageForFilters()) || curr->compositingState() == PaintsIntoOwnBacking || curr->isRootLayer())
             return const_cast<RenderLayer*>(curr);
     }
     return 0;
 }
 
 } // Namespace WebCore