Highlight relfected XSS vectors in view-source page.

Source/core/html/HTMLViewSourceDocument.h

 /*
  * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 22 matching lines @@
 class HTMLTableSectionElement;
 class HTMLToken;
 
 class HTMLViewSourceDocument FINAL : public HTMLDocument {
 public:
     static PassRefPtrWillBeRawPtr<HTMLViewSourceDocument> create(const DocumentInit& initializer, const String& mimeType)
     {
         return adoptRefWillBeRefCountedGarbageCollected(new HTMLViewSourceDocument(initializer, mimeType));
     }
 
-    void addSource(const String&, HTMLToken&);
+    void addSource(const String&, HTMLToken&, bool dangerous);

[Mike West, 2014/05/29 09:29:48]

Nit: Would you mind changing |dangerous| here and |highlight| below into an enum
so that the purpose is clear at the callsite? Perhaps something like
TOKEN_CONSIDERED_XSS and TOKEN_CONSIDERED_SAFE?

 
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
     HTMLViewSourceDocument(const DocumentInit&, const String& mimeType);
 
     virtual PassRefPtrWillBeRawPtr<DocumentParser> createParser() OVERRIDE;
 
     void processDoctypeToken(const String& source, HTMLToken&);
     void processEndOfFileToken(const String& source, HTMLToken&);
-    void processTagToken(const String& source, HTMLToken&);
+    void processTagToken(const String& source, HTMLToken&, bool highlight);

[eseidel, 2014/05/29 14:28:11]

All of these bools are hard to read at callsites:

void processTagToken(source, token, true);  // What does true mean??

Hence, as Mike recommends above, we try to use enums instead.  Even if they're
only used in one place once.

enum ViewSourceHighlight {
   HightlightToken,
   DoNotHighlightToken,
}

or whatever the appropriate choices are.  You can define it inside the class or
not, up to you.

[jww, 2014/05/29 18:35:01]

Just as a further thought that I could see future uses for this where we might
want to highlight different colors for different purposes, and such an enum
would be more flexible for that.

     void processCommentToken(const String& source, HTMLToken&);
-    void processCharacterToken(const String& source, HTMLToken&);
+    void processCharacterToken(const String& source, HTMLToken&, bool highlight);
 
     void createContainingTable();
     PassRefPtr<Element> addSpanWithClassName(const AtomicString&);
     void addLine(const AtomicString& className);
     void finishLine();
-    void addText(const String& text, const AtomicString& className);
+    void addText(const String& text, const AtomicString& className, bool highlight = false);
     int addRange(const String& source, int start, int end, const AtomicString& className, bool isLink = false, bool isAnchor = false, const AtomicString& link = nullAtom);
     PassRefPtr<Element> addLink(const AtomicString& url, bool isAnchor);
     PassRefPtr<Element> addBase(const AtomicString& href);
 
     String m_type;
     RefPtrWillBeMember<Element> m_current;
     RefPtrWillBeMember<HTMLTableSectionElement> m_tbody;
     RefPtrWillBeMember<HTMLTableCellElement> m_td;
     int m_lineNumber;
 };
 
 }
 
 #endif // HTMLViewSourceDocument_h