Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 301803002: Extract tree root responsibility out of HTMLImportsController. (Closed)

Created:
6 years, 6 months ago by dglazkov
Modified:
6 years, 6 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Extract tree root responsibility out of HTMLImportsController. The HTMLImportsController wishes to become more of an Actor-style object, and it being a root of the import tree leads to ambiguities in responsibilities. So we should split these responsibilities cleanly. R=morrita BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175108

Patch Set 1 #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -75 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImport.h View 4 chunks +7 lines, -10 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A Source/core/html/imports/HTMLImportTreeRoot.h View 1 chunk +39 lines, -0 lines 0 comments Download
A Source/core/html/imports/HTMLImportTreeRoot.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.h View 6 chunks +6 lines, -12 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.cpp View 1 6 chunks +6 lines, -50 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dglazkov
6 years, 6 months ago (2014-05-28 17:23:45 UTC) #1
dglazkov
Depends on https://codereview.chromium.org/303643005/.
6 years, 6 months ago (2014-05-28 17:28:50 UTC) #2
Hajime Morrita
lgtm assuming tests pass. YOU MADE IT!
6 years, 6 months ago (2014-05-28 20:38:52 UTC) #3
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 6 months ago (2014-05-28 23:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/301803002/1
6 years, 6 months ago (2014-05-28 23:45:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-29 01:01:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 01:25:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/21268)
6 years, 6 months ago (2014-05-29 01:25:03 UTC) #8
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 6 months ago (2014-05-29 16:34:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/301803002/20001
6 years, 6 months ago (2014-05-29 16:36:59 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 07:57:51 UTC) #11
Message was sent while issue was closed.
Change committed as 175108

Powered by Google App Engine
This is Rietveld 408576698