Issue 3018006: grit: Set first_id XML attribute as a string.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3018006: grit: Set first_id XML attribute as a string. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Evan Stade

Modified:
3 years, 11 months ago

Reviewers:
tony

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

grit: Set first_id XML attribute as a string. BUG=none TEST=compile works again (not sure why it was only failing for me and a few others) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52772

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/grit/grit/node/misc.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results:

Total messages: 2 (0 generated)

tony

4 years, 10 months ago (2010-07-16 23:49:29 UTC) #2

LGTM.  Sorry for the breakage.  I wonder why this only impacts a few people.