tools/grit/grit/node/misc.py - Issue 3018006: grit: Set first_id XML attribute as a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/node/misc.py

Issue 3018006: grit: Set first_id XML attribute as a string. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit/node/misc.py

diff --git a/tools/grit/grit/node/misc.py b/tools/grit/grit/node/misc.py

index 62055a7205362c27e3bf438ed448d1974b144c0d..6ede0c6e5c89e7da3df1514f17e838e276cf16e8 100644

--- a/tools/grit/grit/node/misc.py

+++ b/tools/grit/grit/node/misc.py

@@ -282,7 +282,7 @@ class GritNode(base.Node):

raise e

try:

- node.attrs['first_id'] = id_list.pop(0)

+ node.attrs['first_id'] = str(id_list.pop(0))

except IndexError, e:

raise Exception('Please update %s and add a first id for %s (%s).'

% (first_id_filename, filename, node.name))

« no previous file with comments | « no previous file | no next file » | no next file with comments »