ui/gl/gl_image_android_native_buffer.h - Issue 301793003: During image destroy, delete textures only if we have a GL context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_image_android_native_buffer.h

Issue 301793003: During image destroy, delete textures only if we have a GL context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: prevent crash when accessing destroyed glimage while doing bind/releaseTexImage. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_image_android_native_buffer.h

diff --git a/ui/gl/gl_image_android_native_buffer.h b/ui/gl/gl_image_android_native_buffer.h

index 34f99b4f9a676a8a12d988797594ab789256e676..00f06d0646ab24edcc04e6fc6227f700d0d2bcf2 100644

--- a/ui/gl/gl_image_android_native_buffer.h

+++ b/ui/gl/gl_image_android_native_buffer.h

@@ -16,7 +16,7 @@ class GL_EXPORT GLImageAndroidNativeBuffer : public GLImageEGL {

bool Initialize(EGLClientBuffer native_buffer);

// Overridden from GLImage:

- virtual void Destroy() OVERRIDE;

+ virtual void Destroy(bool have_context) OVERRIDE;

virtual bool BindTexImage(unsigned target) OVERRIDE;

virtual void WillUseTexImage() OVERRIDE;

virtual void DidUseTexImage() OVERRIDE;

« gpu/command_buffer/service/image_manager.cc ('K') | « ui/gl/gl_image.h ('k') | ui/gl/gl_image_android_native_buffer.cc » ('j') | no next file with comments »