Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: ui/gl/gl_image_egl.cc

Issue 301793003: During image destroy, delete textures only if we have a GL context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Destroy GLImage during ContextGroup destroy Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_image_egl.cc
diff --git a/ui/gl/gl_image_egl.cc b/ui/gl/gl_image_egl.cc
index 5531c8d4528defaf11f5a11b42a86934c5921528..088fa287cd3ca485461caff7692b83180fb7916d 100644
--- a/ui/gl/gl_image_egl.cc
+++ b/ui/gl/gl_image_egl.cc
@@ -11,7 +11,9 @@ namespace gfx {
GLImageEGL::GLImageEGL(gfx::Size size)
: egl_image_(EGL_NO_IMAGE_KHR), size_(size) {}
-GLImageEGL::~GLImageEGL() { Destroy(); }
+GLImageEGL::~GLImageEGL() {
+ Destroy(false);
reveman 2014/05/29 16:30:34 No call to Destroy in dtor please. Instead verify
+}
bool GLImageEGL::Initialize(EGLenum target,
EGLClientBuffer buffer,
@@ -31,7 +33,7 @@ bool GLImageEGL::Initialize(EGLenum target,
return true;
}
-void GLImageEGL::Destroy() {
+void GLImageEGL::Destroy(bool have_context) {
if (egl_image_ != EGL_NO_IMAGE_KHR) {
eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image_);
egl_image_ = EGL_NO_IMAGE_KHR;

Powered by Google App Engine
This is Rietveld 408576698