gpu/command_buffer/service/texture_definition.cc - Issue 301793003: During image destroy, delete textures only if we have a GL context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_definition.cc

Issue 301793003: During image destroy, delete textures only if we have a GL context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Destroy GLImage during ContextGroup destroy Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/image_manager.cc ('K') | « gpu/command_buffer/service/stream_texture_manager_in_process_android.cc ('k') | ui/gl/gl_image.h » ('j') | ui/gl/gl_image_android_native_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_definition.cc

diff --git a/gpu/command_buffer/service/texture_definition.cc b/gpu/command_buffer/service/texture_definition.cc

index 24382f0da39734390ccedd940d6aac2d8551afa3..a3335294d61542e7fe36823899994f3ad7f1c23d 100644

--- a/gpu/command_buffer/service/texture_definition.cc

+++ b/gpu/command_buffer/service/texture_definition.cc

@@ -24,7 +24,7 @@ class GLImageSync : public gfx::GLImage {

const scoped_refptr<NativeImageBuffer>& buffer);

// Implement GLImage.

- virtual void Destroy() OVERRIDE;

+ virtual void Destroy(bool have_context) OVERRIDE;

virtual gfx::Size GetSize() OVERRIDE;

virtual bool BindTexImage(unsigned target) OVERRIDE;

virtual void ReleaseTexImage(unsigned target) OVERRIDE;

@@ -55,7 +55,8 @@ GLImageSync::~GLImageSync() {

buffer_->RemoveClient(this);

}

-void GLImageSync::Destroy() {}

+void GLImageSync::Destroy(bool have_context) {

gfx::Size GLImageSync::GetSize() {

NOTREACHED();