gpu/command_buffer/service/context_group.cc - Issue 301793003: During image destroy, delete textures only if we have a GL context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/context_group.cc

Issue 301793003: During image destroy, delete textures only if we have a GL context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: WIP - review comments addressed. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/gpu_channel.cc ('K') | « content/common/gpu/stream_texture_android.cc ('k') | gpu/command_buffer/service/image_manager.h » ('j') | gpu/command_buffer/service/image_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/context_group.cc

diff --git a/gpu/command_buffer/service/context_group.cc b/gpu/command_buffer/service/context_group.cc

index ba0437bfd4e389158b767c2c1398b41c33eb4d55..5e812ab6c090a2506ea875b21621feec0c0f480d 100644

--- a/gpu/command_buffer/service/context_group.cc

+++ b/gpu/command_buffer/service/context_group.cc

@@ -324,6 +324,9 @@ void ContextGroup::Destroy(GLES2Decoder* decoder, bool have_context) {

shader_manager_.reset();

}

+ if (image_manager_)

+ image_manager_->Destroy(have_context);

reveman 2014/06/03 13:57:39 This is not right. What if the image manager is us

sohanjg 2014/06/03 15:09:20 Done.

memory_tracker_ = NULL;

}