During image destroy, delete textures only if we have a GL context.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/memory/shared_memory.h"
@@ skipping 928 matching lines @@
   if (!image)
     return;
 
   // For Android specific workaround.
   if (context_group_->feature_info()->workarounds().release_image_after_use)
     image->SetReleaseAfterUse();
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
+    if (image_manager->LookupImage(id)) {
+      LOG(ERROR) << "Image already exists with same ID.";
+      return;
+    }
     image_manager->AddImage(image.get(), id);
   }
 }
 
 void GpuCommandBufferStub::OnDestroyGpuMemoryBuffer(int32 id) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyGpuMemoryBuffer");
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
+    if (!image_manager->LookupImage(id)) {
+      LOG(ERROR) << "Image with ID doesn't exist.";

[no sievers, 2014/07/28 17:38:25]

nit: maybe the checks here and above fit better inside ImageManager?
Then you could maybe avoid doing two lookups. I think hash_map::erase() returns
the number of elements erased.

[reveman, 2014/07/28 18:00:00]

I suggested we check this here and just DCHECK in the image manager as whether
it's OK to crash or not depends on the command buffer. I'm fine doing it the
other way though. AddImage just needs to be able to return false.

[sohanjg, 2014/07/30 10:30:26]

sievers@ should we take the checks back to imagemanager or you are ok at this
being here ?

+      return;
+    }
     image_manager->RemoveImage(id);
   }
 }
 
 void GpuCommandBufferStub::SendConsoleMessage(
     int32 id,
     const std::string& message) {
   GPUCommandBufferConsoleMessage console_message;
   console_message.id = id;
   console_message.message = message;
@@ skipping 83 matching lines @@
   if (decoder_)
     decoder_->LoseContext(GL_UNKNOWN_CONTEXT_RESET_ARB);
   command_buffer_->SetParseError(gpu::error::kLostContext);
 }
 
 uint64 GpuCommandBufferStub::GetMemoryUsage() const {
   return GetMemoryManager()->GetClientMemoryUsage(this);
 }
 
 }  // namespace content