During image destroy, delete textures only if we have a GL context.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/memory/shared_memory.h"
@@ skipping 928 matching lines @@
   if (!image)
     return;
 
   // For Android specific workaround.
   if (context_group_->feature_info()->workarounds().release_image_after_use)
     image->SetReleaseAfterUse();
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
+    if (id <= 0) {

[reveman, 2014/07/25 19:00:23]

I don't think this check should exist. Either we change the IPC to uint32 or fix
so int32 is properly supported. I vote for the later as it looks like all we
have to do is int32 instead uint32 as the key in the image manager hash_map.

[sohanjg, 2014/07/26 10:42:22]

Done.

+      LOG(ERROR) << "Cannot add image with non-positive ID.";
+      return;
+    }
     image_manager->AddImage(image.get(), id);

[reveman, 2014/07/25 19:00:23]

You need to check for collisions before this call. We can't add the image if one
already exists with the same ID.

[sohanjg, 2014/07/26 10:42:23]

Done.

   }
 }
 
 void GpuCommandBufferStub::OnDestroyGpuMemoryBuffer(int32 id) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyGpuMemoryBuffer");
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
+    if (id <= 0) {

[reveman, 2014/07/25 19:00:23]

this check shouldn't exist.

[sohanjg, 2014/07/26 10:42:22]

Done.

+      LOG(ERROR) << "Cannot remove image with non-positive ID.";
+      return;
+    }
+    DCHECK(image_manager->LookupImage(id));

[reveman, 2014/07/25 19:00:23]

A DCHECK is not OK here. We need to log an error and early out to be sure that a
compromised renderer can't cause the GPU process to crash or behave in undefined
way.

[sohanjg, 2014/07/26 10:42:23]

Done.

     image_manager->RemoveImage(id);
   }
 }
 
 void GpuCommandBufferStub::SendConsoleMessage(
     int32 id,
     const std::string& message) {
   GPUCommandBufferConsoleMessage console_message;
   console_message.id = id;
   console_message.message = message;
@@ skipping 83 matching lines @@
   if (decoder_)
     decoder_->LoseContext(GL_UNKNOWN_CONTEXT_RESET_ARB);
   command_buffer_->SetParseError(gpu::error::kLostContext);
 }
 
 uint64 GpuCommandBufferStub::GetMemoryUsage() const {
   return GetMemoryManager()->GetClientMemoryUsage(this);
 }
 
 }  // namespace content