During image destroy, delete textures only if we have a GL context.

gpu/command_buffer/service/image_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/image_manager.h"
 
 #include "ui/gl/gl_image.h"
 
 namespace gpu {
 namespace gles2 {
 
 ImageManager::ImageManager() {
 }
 
 ImageManager::~ImageManager() {
 }
 
+void ImageManager::Destroy(bool have_context) {
+  for (GLImageMap::const_iterator iter = images_.begin(); iter != images_.end();
+       ++iter)
+    iter->second.get()->Destroy(have_context);
+  images_.clear();
+}
+
 void ImageManager::AddImage(gfx::GLImage* image, int32 service_id) {
   images_[service_id] = image;
 }
 
 void ImageManager::RemoveImage(int32 service_id) {
+  LookupImage(service_id)->Destroy(true);

[sohanjg, 2014/07/24 13:24:10]

Will it be safe to assume we have context while destroying gpu mem buffers ?
and, do we need validation for the service id and the image returned by look up
?

[reveman, 2014/07/24 13:51:55]

It's safe to assume that you have a context here.

I don't think it's safe to assume that service_id is valid. You'll have to fix
that. Also, please avoid 2 service_id lookups here and instead erase using an
iterator.

[sohanjg, 2014/07/24 15:26:59]

Done.

   images_.erase(service_id);
 }
 
 gfx::GLImage* ImageManager::LookupImage(int32 service_id) {
   GLImageMap::const_iterator iter = images_.find(service_id);
   if (iter != images_.end())
     return iter->second.get();
 
   return NULL;
 }
 
 }  // namespace gles2
 }  // namespace gpu