Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: gpu/command_buffer/service/image_manager.h

Issue 301793003: During image destroy, delete textures only if we have a GL context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Destroy GLImage during ContextGroup destroy Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_ 5 #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_ 6 #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "gpu/command_buffer/service/gpu_memory_buffer_manager.h" 11 #include "gpu/command_buffer/service/gpu_memory_buffer_manager.h"
12 #include "gpu/gpu_export.h" 12 #include "gpu/gpu_export.h"
13 13
14 namespace gfx { 14 namespace gfx {
15 class GLImage; 15 class GLImage;
16 } 16 }
17 17
18 namespace gpu { 18 namespace gpu {
19 namespace gles2 { 19 namespace gles2 {
20 20
21 // Interface used by the cmd decoder to lookup images. 21 // Interface used by the cmd decoder to lookup images.
22 class GPU_EXPORT ImageManager 22 class GPU_EXPORT ImageManager
23 : public GpuMemoryBufferManagerInterface, 23 : public GpuMemoryBufferManagerInterface,
24 public base::RefCounted<ImageManager> { 24 public base::RefCounted<ImageManager> {
25 public: 25 public:
26 ImageManager(); 26 ImageManager();
27 27
28 virtual void Destroy(bool have_context);
reveman 2014/05/29 16:30:34 Why virtual?
29
28 // Overridden from GpuMemoryBufferManagerInterface: 30 // Overridden from GpuMemoryBufferManagerInterface:
29 virtual void RegisterGpuMemoryBuffer(int32 id, 31 virtual void RegisterGpuMemoryBuffer(int32 id,
30 gfx::GpuMemoryBufferHandle buffer, 32 gfx::GpuMemoryBufferHandle buffer,
31 size_t width, 33 size_t width,
32 size_t height, 34 size_t height,
33 unsigned internalformat) OVERRIDE; 35 unsigned internalformat) OVERRIDE;
34 virtual void UnregisterGpuMemoryBuffer(int32 id) OVERRIDE; 36 virtual void UnregisterGpuMemoryBuffer(int32 id) OVERRIDE;
35 37
36 void AddImage(gfx::GLImage* gl_image, int32 service_id); 38 void AddImage(gfx::GLImage* gl_image, int32 service_id);
37 void RemoveImage(int32 service_id); 39 void RemoveImage(int32 service_id);
(...skipping 11 matching lines...) Expand all
49 GLImageMap gl_images_; 51 GLImageMap gl_images_;
50 bool release_after_use_; 52 bool release_after_use_;
51 53
52 DISALLOW_COPY_AND_ASSIGN(ImageManager); 54 DISALLOW_COPY_AND_ASSIGN(ImageManager);
53 }; 55 };
54 56
55 } // namespage gles2 57 } // namespage gles2
56 } // namespace gpu 58 } // namespace gpu
57 59
58 #endif // GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_ 60 #endif // GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698