During image destroy, delete textures only if we have a GL context.

content/common/gpu/gpu_channel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include "content/common/gpu/gpu_channel.h"
 
@@ skipping 386 matching lines @@
 
   channel_id_ = IPC::Channel::GenerateVerifiedChannelID("gpu");
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   log_messages_ = command_line->HasSwitch(switches::kLogPluginMessages);
 }
 
 GpuChannel::~GpuChannel() {
   STLDeleteElements(&deferred_messages_);
   if (preempting_flag_.get())
     preempting_flag_->Reset();
+
+  bool lost_context = false;
+  for (StubMap::Iterator<GpuCommandBufferStub> it(&stubs_); !it.IsAtEnd();
+       it.Advance()) {
+    lost_context = it.GetCurrentValue()->CheckContextLost();

[reveman, 2014/06/04 15:29:35]

This will set lost_context to whatever is returned from the CheckContextLost()
call on the last stub. How is that supposed to help?

[sohanjg, 2014/06/05 02:57:57]

Can you please suggest how we should get the have_context here? Decoder
generally maintains the context, so i thot of querying the cmd buffer stub for
it.
Should we just pass true here ?

[sohanjg, 2014/06/05 06:33:57]

When i checked, the stubmap size is 1, how about we check for
decoder()->MakeCurrent on this stub (that is the value we passed to context
group also).
If we have multiple stubs, still we will have 1 image manager for the gpu
channel,how can we handle then? or should we move image manager
creation/handling to stub ?

[reveman, 2014/06/05 15:58:01]

We'll have one image manager per stub once we've Create/DeleteImage IPC refactor
is done. This is why I suggested you wait with this until that is complete.

[sohanjg, 2014/06/06 02:30:03]

I see. Is waiting for the refactor the only option then ? Or we can assume stub
size as 1, and work with the decoder makecurrent value temporarily and mark a
todo to revisit once the refactor lands ?

+  }
+  if (image_manager_)
+    image_manager_->Destroy(!lost_context);
 }
 
 void GpuChannel::Init(base::MessageLoopProxy* io_message_loop,
                       base::WaitableEvent* shutdown_event) {
   DCHECK(!channel_.get());
 
   // Map renderer ID to a (single) channel to that process.
   channel_.reset(new IPC::SyncChannel(
       channel_id_,
       IPC::Channel::MODE_SERVER,
@@ skipping 420 matching lines @@
 uint64 GpuChannel::GetMemoryUsage() {
   uint64 size = 0;
   for (StubMap::Iterator<GpuCommandBufferStub> it(&stubs_);
        !it.IsAtEnd(); it.Advance()) {
     size += it.GetCurrentValue()->GetMemoryUsage();
   }
   return size;
 }
 
 }  // namespace content