Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 301793002: Add new WebRTC Video API to libpeerconnection.so. (Closed)

Created:
6 years, 6 months ago by pbos
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add new WebRTC Video API to libpeerconnection.so. Adding new-API files to libjingle.gyp to prevent linker errors when submitting wiring up the API into libjingle. R=ronghuawu@chromium.org BUG=webrtc:1788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pbos
6 years, 6 months ago (2014-05-28 08:51:25 UTC) #1
Ronghua Wu (Left Chromium)
lgtm Do you want to add the unit test to the build as well? Or ...
6 years, 6 months ago (2014-05-28 16:55:08 UTC) #2
pbos
The unittest is run part of libjingle_media_tests in webrtc already. Is there another appropriate target ...
6 years, 6 months ago (2014-05-29 00:33:26 UTC) #3
Ronghua Wu (Left Chromium)
NM, I thought this is a webrtc cl. LGTM
6 years, 6 months ago (2014-05-29 04:55:36 UTC) #4
pbos
The CQ bit was checked by pbos@chromium.org
6 years, 6 months ago (2014-05-30 11:27:32 UTC) #5
pbos
The CQ bit was unchecked by pbos@chromium.org
6 years, 6 months ago (2014-05-30 11:27:35 UTC) #6
pbos
The CQ bit was checked by pbos@chromium.org
6 years, 6 months ago (2014-05-30 11:28:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pbos@chromium.org/301793002/1
6 years, 6 months ago (2014-05-30 11:29:53 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:43:12 UTC) #9
Message was sent while issue was closed.
Change committed as 273827

Powered by Google App Engine
This is Rietveld 408576698