Make sure snap_page combined iframe serialized dom

telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
index fc3cf2be44d2da05fe30c6d9c8f7d3d5dfc41012..cf4b1da4f147accfd0c0bd06593e654553a75f86 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
@@ -9,13 +9,12 @@ class InspectorRuntime(object):
     self._inspector_websocket = inspector_websocket
     self._inspector_websocket.RegisterDomain('Runtime', self._OnNotification)
     self._contexts_enabled = False
-    self._max_context_id = None
+    self._all_context_ids = None
 
   def _OnNotification(self, msg):
     if (self._contexts_enabled and
         msg['method'] == 'Runtime.executionContextCreated'):
-      self._max_context_id = max(self._max_context_id,
-                                 msg['params']['context']['id'])
+      self._all_context_ids.add(msg['params']['context']['id'])
 
   def Execute(self, expr, context_id, timeout):
     self.Evaluate(expr + '; 0;', context_id, timeout)
@@ -67,9 +66,10 @@ class InspectorRuntime(object):
     """
     if not self._contexts_enabled:
       self._contexts_enabled = True
+      self._all_context_ids = set()
       self._inspector_websocket.SyncRequest({'method': 'Runtime.enable'},
                                             timeout=30)
-    return self._max_context_id
+    return self._all_context_ids

[wkorman, 2017/09/20 20:11:04]

Is there a doc comment we should update or add here to note the change in return
type/contents? Also, unit test?

[nednguyen, 2017/09/26 13:01:34]

We have unittest for this

 
   def RunInspectorCommand(self, command, timeout):
     """Runs an inspector command.