Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: telemetry/telemetry/internal/browser/web_contents.py

Issue 3017573002: Make sure snap_page combined iframe serialized dom
Patch Set: . Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/web_contents.py
diff --git a/telemetry/telemetry/internal/browser/web_contents.py b/telemetry/telemetry/internal/browser/web_contents.py
index f4669f3d9a88013fe45493d9518656e3d12298f6..542c976cbfee3974d00ef44eea765bdb5770cbc9 100644
--- a/telemetry/telemetry/internal/browser/web_contents.py
+++ b/telemetry/telemetry/internal/browser/web_contents.py
@@ -239,7 +239,13 @@ class WebContents(object):
return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
def EnableAllContexts(self):
- """Enable all contexts in a page. Returns the number of available contexts.
+ """Enable all contexts in a page. Returns all available context ids.
+
+ Returns:
+ A list of frame context ids. Each |context_id| can be used for
+ executing Javascript in the corresponding iframe through
+ tab.ExecuteJavaScript(..., context_id=context_id) and
+ ab.EvaluateJavaScript(..., context_id=context_id).
wkorman 2017/09/20 20:11:04 Missing 't'
Raises:
exceptions.WebSocketDisconnected

Powered by Google App Engine
This is Rietveld 408576698