Pepper: PnaclResources cleanup.

Pepper: PnaclResources cleanup.

This simplifies some code in PnaclResources a bit in anticipation of moving
more code out of the trusted plugin.

BUG=239656

[bbudge, 2014-05-27 20:54:07]

https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):

https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:65: nacl::string
full_url = "chrome://pnacl-translator/pnacl.json";
Could we use kPnaclBaseUrl here?

[teravest, 2014-05-27 20:58:08]

On Tue, May 27, 2014 at 2:54 PM,  <bbudge@chromium.org> wrote:
>
>
https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):
>
>
https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:65:
>
> nacl::string full_url = "chrome://pnacl-translator/pnacl.json";
> Could we use kPnaclBaseUrl here?

I suppose, though I didn't see much advantage in sharing the string
constant. I plan on moving that constant out of the trusted plugin
soon, since GetPnaclResourceInfo() isn't used on any other URLs.

>
> https://codereview.chromium.org/301743003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bbudge, 2014-05-27 21:00:24]

https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):

https://codereview.chromium.org/301743003/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:65: nacl::string
full_url = "chrome://pnacl-translator/pnacl.json";
On 2014/05/27 20:54:07, bbudge wrote:
> Could we use kPnaclBaseUrl here?

Or define a string constant above for the path since you don't have to construct
anything. Just seems weird to have one defined with a constant and the other
inline.

[bbudge, 2014-05-27 21:01:10]

LGTM
string is pretty minor issue.