Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 301743002: Revert of Refactor and move ash independent nested accelerator code to ui/wm/core (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Refactor and move ash independent nested accelerator code to ui/wm/core (https://codereview.chromium.org/298703007/) Reason for revert: caused test failures: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19236 NestedAcceleratorTest.AcceleratorsHandled (run #1): [ RUN ] NestedAcceleratorTest.AcceleratorsHandled Backtrace: ui::PlatformEventSource::OverrideDispatcher [0x0028B66D+253] wm::test::NestedAcceleratorTest_AcceleratorsHandled_Test::TestBody [0x00455D37+215] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329] testing::Test::Run [0x004EFF9E+174] testing::TestInfo::Run [0x004F023D+221] testing::TestCase::Run [0x004F00DF+239] testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337] testing::UnitTest::Run [0x004F0393+211] RUN_ALL_TESTS [0x004A0EDF+15] base::TestSuite::Run [0x004A1129+233] base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27] base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26] base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74] base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47] base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921] base::LaunchUnitTests [0x00498D15+37] main [0x0041681C+140] __tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626) mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466) BaseThreadInitThunk [0x76568624+14] RtlInitializeExceptionChain [0x773CAC69+133] RtlInitializeExceptionChain [0x773CAC3C+88] NestedAcceleratorTest.AssociatedWindowAboveLockScreen (run #1): [ RUN ] NestedAcceleratorTest.AssociatedWindowAboveLockScreen Backtrace: ui::PlatformEventSource::OverrideDispatcher [0x0286B66D+253] wm::test::NestedAcceleratorTest_AssociatedWindowAboveLockScreen_Test::TestBody [0x004563B5+517] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329] testing::Test::Run [0x004EFF9E+174] testing::TestInfo::Run [0x004F023D+221] testing::TestCase::Run [0x004F00DF+239] testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726] testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337] testing::UnitTest::Run [0x004F0393+211] RUN_ALL_TESTS [0x004A0EDF+15] base::TestSuite::Run [0x004A1129+233] base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27] base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26] base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74] base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47] base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921] base::LaunchUnitTests [0x00498D15+37] main [0x0041681C+140] __tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626) mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466) BaseThreadInitThunk [0x76568624+14] RtlInitializeExceptionChain [0x773CAC69+133] RtlInitializeExceptionChain [0x773CAC3C+88] Original issue's description: > Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core > > I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740 > > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272995 TBR=ben@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -690 lines) Patch
A ash/accelerators/accelerator_dispatcher.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ash/accelerators/accelerator_dispatcher.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A ash/accelerators/accelerator_dispatcher_linux.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A ash/accelerators/accelerator_dispatcher_win.cc View 1 chunk +64 lines, -0 lines 0 comments Download
D ash/accelerators/nested_accelerator_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ash/accelerators/nested_accelerator_delegate.cc View 1 chunk +0 lines, -75 lines 0 comments Download
A ash/accelerators/nested_dispatcher_controller.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ash/accelerators/nested_dispatcher_controller.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +151 lines, -0 lines 0 comments Download
M ash/ash.gyp View 4 chunks +8 lines, -3 lines 0 comments Download
M ash/shell.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M ui/wm/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/wm/core/nested_accelerator_controller.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/wm/core/nested_accelerator_controller.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/wm/core/nested_accelerator_controller_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D ui/wm/core/nested_accelerator_delegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher_linux.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher_win.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M ui/wm/wm.gyp View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
Created Revert of Refactor and move ash independent nested accelerator code to ui/wm/core
6 years, 6 months ago (2014-05-27 19:01:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/301743002/1
6 years, 6 months ago (2014-05-27 19:02:14 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-27 19:04:12 UTC) #3
Message was sent while issue was closed.
Change committed as 273003

Powered by Google App Engine
This is Rietveld 408576698