Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 301733006: Zoom Extension API (chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/web_view/web_view_guest.h" 5 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
11 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 11 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
12 #include "chrome/browser/extensions/api/web_request/web_request_api.h" 12 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
13 #include "chrome/browser/extensions/api/webview/webview_api.h" 13 #include "chrome/browser/extensions/api/webview/webview_api.h"
14 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 14 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
15 #include "chrome/browser/extensions/extension_renderer_state.h" 15 #include "chrome/browser/extensions/extension_renderer_state.h"
16 #include "chrome/browser/extensions/menu_manager.h" 16 #include "chrome/browser/extensions/menu_manager.h"
17 #include "chrome/browser/extensions/script_executor.h" 17 #include "chrome/browser/extensions/script_executor.h"
18 #include "chrome/browser/favicon/favicon_tab_helper.h" 18 #include "chrome/browser/favicon/favicon_tab_helper.h"
19 #include "chrome/browser/geolocation/geolocation_permission_context.h" 19 #include "chrome/browser/geolocation/geolocation_permission_context.h"
20 #include "chrome/browser/geolocation/geolocation_permission_context_factory.h" 20 #include "chrome/browser/geolocation/geolocation_permission_context_factory.h"
21 #include "chrome/browser/guest_view/guest_view_constants.h" 21 #include "chrome/browser/guest_view/guest_view_constants.h"
22 #include "chrome/browser/guest_view/guest_view_manager.h" 22 #include "chrome/browser/guest_view/guest_view_manager.h"
23 #include "chrome/browser/guest_view/web_view/web_view_constants.h" 23 #include "chrome/browser/guest_view/web_view/web_view_constants.h"
24 #include "chrome/browser/guest_view/web_view/web_view_permission_types.h" 24 #include "chrome/browser/guest_view/web_view/web_view_permission_types.h"
25 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h" 25 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h"
26 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 26 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
27 #include "chrome/browser/ui/pdf/pdf_tab_helper.h" 27 #include "chrome/browser/ui/pdf/pdf_tab_helper.h"
28 #include "chrome/browser/ui/zoom/zoom_controller.h"
28 #include "chrome/common/chrome_version_info.h" 29 #include "chrome/common/chrome_version_info.h"
29 #include "chrome/common/render_messages.h" 30 #include "chrome/common/render_messages.h"
30 #include "content/public/browser/browser_thread.h" 31 #include "content/public/browser/browser_thread.h"
31 #include "content/public/browser/child_process_security_policy.h" 32 #include "content/public/browser/child_process_security_policy.h"
32 #include "content/public/browser/host_zoom_map.h"
33 #include "content/public/browser/native_web_keyboard_event.h" 33 #include "content/public/browser/native_web_keyboard_event.h"
34 #include "content/public/browser/navigation_entry.h" 34 #include "content/public/browser/navigation_entry.h"
35 #include "content/public/browser/notification_details.h" 35 #include "content/public/browser/notification_details.h"
36 #include "content/public/browser/notification_service.h" 36 #include "content/public/browser/notification_service.h"
37 #include "content/public/browser/notification_source.h" 37 #include "content/public/browser/notification_source.h"
38 #include "content/public/browser/notification_types.h" 38 #include "content/public/browser/notification_types.h"
39 #include "content/public/browser/render_process_host.h" 39 #include "content/public/browser/render_process_host.h"
40 #include "content/public/browser/render_view_host.h" 40 #include "content/public/browser/render_view_host.h"
41 #include "content/public/browser/resource_request_details.h" 41 #include "content/public/browser/resource_request_details.h"
42 #include "content/public/browser/site_instance.h" 42 #include "content/public/browser/site_instance.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 int view_instance_id) { 157 int view_instance_id) {
158 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO)); 158 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
159 ExtensionWebRequestEventRouter::GetInstance()->RemoveWebViewEventListeners( 159 ExtensionWebRequestEventRouter::GetInstance()->RemoveWebViewEventListeners(
160 profile, 160 profile,
161 extension_id, 161 extension_id,
162 embedder_process_id, 162 embedder_process_id,
163 view_instance_id); 163 view_instance_id);
164 } 164 }
165 165
166 void AttachWebViewHelpers(WebContents* contents) { 166 void AttachWebViewHelpers(WebContents* contents) {
167 // Create a zoom controller for the guest contents give it access to
168 // GetZoomLevel() and and SetZoomLevel() in WebViewGuest.
169 // TODO(wjmaclean) This currently uses the same HostZoomMap as the browser
170 // context, but we eventually want to isolate the guest contents from zoom
171 // changes outside the guest (e.g. in the main browser), so we should
172 // create a separate HostZoomMap for the guest.
173 ZoomController::CreateForWebContents(contents);
174
167 FaviconTabHelper::CreateForWebContents(contents); 175 FaviconTabHelper::CreateForWebContents(contents);
168 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents( 176 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
169 contents); 177 contents);
170 #if defined(ENABLE_PLUGINS) 178 #if defined(ENABLE_PLUGINS)
171 PluginPermissionHelper::CreateForWebContents(contents); 179 PluginPermissionHelper::CreateForWebContents(contents);
172 #endif 180 #endif
173 #if defined(ENABLE_PRINTING) 181 #if defined(ENABLE_PRINTING)
174 #if defined(ENABLE_FULL_PRINTING) 182 #if defined(ENABLE_FULL_PRINTING)
175 printing::PrintViewManager::CreateForWebContents(contents); 183 printing::PrintViewManager::CreateForWebContents(contents);
176 printing::PrintPreviewMessageHandler::CreateForWebContents(contents); 184 printing::PrintPreviewMessageHandler::CreateForWebContents(contents);
(...skipping 847 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 args->SetInteger(webview::kInternalCurrentEntryIndex, 1032 args->SetInteger(webview::kInternalCurrentEntryIndex,
1025 guest_web_contents()->GetController().GetCurrentEntryIndex()); 1033 guest_web_contents()->GetController().GetCurrentEntryIndex());
1026 args->SetInteger(webview::kInternalEntryCount, 1034 args->SetInteger(webview::kInternalEntryCount,
1027 guest_web_contents()->GetController().GetEntryCount()); 1035 guest_web_contents()->GetController().GetEntryCount());
1028 args->SetInteger(webview::kInternalProcessId, 1036 args->SetInteger(webview::kInternalProcessId,
1029 guest_web_contents()->GetRenderProcessHost()->GetID()); 1037 guest_web_contents()->GetRenderProcessHost()->GetID());
1030 DispatchEvent( 1038 DispatchEvent(
1031 new GuestViewBase::Event(webview::kEventLoadCommit, args.Pass())); 1039 new GuestViewBase::Event(webview::kEventLoadCommit, args.Pass()));
1032 1040
1033 // Update the current zoom factor for the new page. 1041 // Update the current zoom factor for the new page.
1034 current_zoom_factor_ = content::ZoomLevelToZoomFactor( 1042 ZoomController* zoom_controller =
1035 content::HostZoomMap::GetZoomLevel(guest_web_contents())); 1043 ZoomController::FromWebContents(guest_web_contents());
1044 DCHECK(zoom_controller);
1045 current_zoom_factor_ = zoom_controller->GetZoomLevel();
1036 1046
1037 if (is_main_frame) { 1047 if (is_main_frame) {
1038 chromevox_injected_ = false; 1048 chromevox_injected_ = false;
1039 main_frame_id_ = frame_id; 1049 main_frame_id_ = frame_id;
1040 } 1050 }
1041 } 1051 }
1042 1052
1043 void WebViewGuest::DidFailProvisionalLoad( 1053 void WebViewGuest::DidFailProvisionalLoad(
1044 int64 frame_id, 1054 int64 frame_id,
1045 const base::string16& frame_unique_name, 1055 const base::string16& frame_unique_name,
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 1496
1487 void WebViewGuest::SetName(const std::string& name) { 1497 void WebViewGuest::SetName(const std::string& name) {
1488 if (name_ == name) 1498 if (name_ == name)
1489 return; 1499 return;
1490 name_ = name; 1500 name_ = name;
1491 1501
1492 Send(new ChromeViewMsg_SetName(routing_id(), name_)); 1502 Send(new ChromeViewMsg_SetName(routing_id(), name_));
1493 } 1503 }
1494 1504
1495 void WebViewGuest::SetZoom(double zoom_factor) { 1505 void WebViewGuest::SetZoom(double zoom_factor) {
1506 ZoomController* zoom_controller =
1507 ZoomController::FromWebContents(guest_web_contents());
1508 DCHECK(zoom_controller);
1496 double zoom_level = content::ZoomFactorToZoomLevel(zoom_factor); 1509 double zoom_level = content::ZoomFactorToZoomLevel(zoom_factor);
1497 content::HostZoomMap::SetZoomLevel(guest_web_contents(), zoom_level); 1510 zoom_controller->SetZoomLevel(zoom_level);
1498 1511
1499 scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue()); 1512 scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
1500 args->SetDouble(webview::kOldZoomFactor, current_zoom_factor_); 1513 args->SetDouble(webview::kOldZoomFactor, current_zoom_factor_);
1501 args->SetDouble(webview::kNewZoomFactor, zoom_factor); 1514 args->SetDouble(webview::kNewZoomFactor, zoom_factor);
1502 DispatchEvent( 1515 DispatchEvent(
1503 new GuestViewBase::Event(webview::kEventZoomChange, args.Pass())); 1516 new GuestViewBase::Event(webview::kEventZoomChange, args.Pass()));
1504 1517
1505 current_zoom_factor_ = zoom_factor; 1518 current_zoom_factor_ = zoom_factor;
1506 } 1519 }
1507 1520
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 bool allow, 1668 bool allow,
1656 const std::string& user_input) { 1669 const std::string& user_input) {
1657 WebViewGuest* guest = 1670 WebViewGuest* guest =
1658 WebViewGuest::From(embedder_render_process_id(), new_window_instance_id); 1671 WebViewGuest::From(embedder_render_process_id(), new_window_instance_id);
1659 if (!guest) 1672 if (!guest)
1660 return; 1673 return;
1661 1674
1662 if (!allow) 1675 if (!allow)
1663 guest->Destroy(); 1676 guest->Destroy();
1664 } 1677 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698